GNOME Bugzilla – Bug 620226
Add optional "description" to each tag
Last modified: 2010-06-08 09:44:15 UTC
Created attachment 162432 [details] [review] Diffs to current head of tree to add tag description field. Tags serve many of the same functions that photo catalogs do in other systems. One feature they are missing, though, is a description of the group as a whole. For example, when I apply the tag "Trip to Maine, 2007" to a group of photos, it would be nice if I could add a paragraph or two of description of who was there, what it was like, etc. I have made the changes to add an optional description to each tag. You access the description by right-clicking on a tag and selecting "Edit Tag...". The GUI for doing this is pretty bad, though, because I've never written a GTK app before; it has a text view to show and enter the description, but the whole dialog grows and shrinks with the text box. In addition, the text view has no border and generally looks bad. If somebody can tell me how to improve this I'll be happy to do so, or if it's easy just do this before merging into the main f-spot code base. It would also make sense to use these descriptions when exporting photos, but I'd rather keep the patch small for now. Summary of changes in the patch: * Add "description" column to "tags" database * Add "description" member variable (with getter and setter) to Tag.cs * Add persistance code to TagStore.cs * Add text view to EditTagDialog.cs and EditTagDialog.ui * Change Updater.cs to add column; new database schema is called 7.2.
Hi, am I right in understanding that you would mainly place descriptions onto tags that are basically an album? I'm not sure if adding a description field is the right solution to this problem. In the not so far future we are going to introduce the concept of events/albums. Having a description field on those would be a nicer way to solve this. Am leaning towards not merging this for that reason. The patch itself is clean though, if this was you first attempt at poking at a GTK+ app, well, I'd say you did pretty well. Regarding the textview growing: I think you need to pack it into a scrolledwindow widget. Sorry for not replying to this earlier, I was at the Libre Graphics Meeting (where we redesigned most of the F-Spot user interface). The new stuff that will be coming will fit your use case much better. Am going to close this as WONTFIX for now, but feel free to reopen if you absolutely disagree and want to further discuss this. If you want to help us out hacking towards the holy grail of user interfaces, feel free to hope onto IRC and we'll see how we best get there. Kind regards, Ruben