After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620186 - qtdemux: Export max bitrate for AMR-NB/-WB streams
qtdemux: Export max bitrate for AMR-NB/-WB streams
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-31 21:17 UTC by Arun Raghavan
Modified: 2011-06-15 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtdemux: Export max bitrate for AMR-NB/-WB streams (3.42 KB, patch)
2010-05-31 21:17 UTC, Arun Raghavan
none Details | Review
qtdemux: Export max bitrate for AMR-NB/-WB streams (4.14 KB, patch)
2010-07-27 16:10 UTC, Arun Raghavan
committed Details | Review

Description Arun Raghavan 2010-05-31 21:17:33 UTC
Created attachment 162409 [details] [review]
qtdemux: Export max bitrate for AMR-NB/-WB streams

Attaching a patch that exports the maximum bitrate for AMR-NB and AMR-WB streams encapsulated in 3GP. Doesn't do anything for AMR-WB+ streams, since the metadata in the header does not provide enough information.
Comment 1 Arun Raghavan 2010-07-27 16:10:29 UTC
Created attachment 166658 [details] [review]
qtdemux: Export max bitrate for AMR-NB/-WB streams

This parses the 'damr' atom if present, and exports the maximum bitrate
of the stream using the mode set field to determine the highest bitrate
frame type that might be present.
Comment 2 Arun Raghavan 2010-07-27 16:13:28 UTC
Comment on attachment 162409 [details] [review]
qtdemux: Export max bitrate for AMR-NB/-WB streams

Posting updated patch based on feedback from Tim and Thiago.

The code was wrong at one point. There is no 'dawb' atom. 'damr' is used for both AMR-NB and -WB.
Comment 3 Mark Nauwelaerts 2011-04-26 14:04:31 UTC
Rebased to current git and removed stream->bitrate bits as that field appears to come from another patch on bug #619548.

Will (finally) push following release ...
Comment 4 Mark Nauwelaerts 2011-05-16 11:33:57 UTC
commit 6e2774af55d65c14c628fd1bdc25807808b62b01
Author: Arun Raghavan <arun.raghavan@collabora.co.uk>
Date:   Mon May 31 23:59:59 2010 +0530

    qtdemux: Export max bitrate for AMR-NB/-WB streams
    
    This parses the 'damr' atom if present, and exports the maximum bitrate
    of the stream using the mode set field to determine the highest bitrate
    frame type that might be present.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=620186