After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620126 - Support OAuth 1.0a
Support OAuth 1.0a
Status: RESOLVED FIXED
Product: snowy
Classification: Deprecated
Component: general
git master
Other Linux
: Normal major
: 0.2
Assigned To: snowy-maint
snowy-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-30 21:39 UTC by Sandy Armstrong
Modified: 2010-06-16 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to update the piston version. (89.98 KB, patch)
2010-06-01 01:24 UTC, Olivier Le Thanh Duong 		committed Details | Review
Fix api tests for OAuth 1.0a (3.25 KB, patch)
2010-06-16 12:29 UTC, Leon Handreke 		committed Details | Review

Description Sandy Armstrong 2010-05-30 21:39:41 UTC 
Conboy and other mobile clients might have more trouble interfacing with OAuth 1.0 than Tomboy does, plus 1.0a is more secure.

Need to investigate if newer versions of django-piston have better 1.0a support, and maybe contribute some patches to them to make it happen.
Comment 1 Olivier Le Thanh Duong 2010-06-01 01:24:31 UTC 
Created attachment 162416 [details] [review]
Patch to update the piston version.
Comment 2 Olivier Le Thanh Duong 2010-06-01 01:29:13 UTC 
Hi,
The preceding patch update the piston version embedded in snowy, I checked and it implements Oauth 1.0a. With some patching to fix bugs in conboy it sync fine with it and obviously it works with Tomboy too.

Only trouble with it is that it break older existing installs as a column have been added to the Token model it seems.
Comment 3 Olivier Le Thanh Duong 2010-06-01 13:15:15 UTC 
Here is the bug for conboy with the patch attached https://bugs.maemo.org/show_bug.cgi?id=10469
Comment 4 Leon Handreke 2010-06-16 12:29:25 UTC 
Created attachment 163809 [details] [review]
Fix api tests for OAuth 1.0a

I tested the patch, it seems to work great! (I only tested sync with Tomboy though)

I think sandy mentioned on IRC that the tests need to be updated for this, so I sat down and studied the OAuth protocol and the changes in 1.0a. With this patch all API tests should pass again.
Comment 5 Sandy Armstrong 2010-06-16 14:29:32 UTC 
Sweet, thanks for the test fix Leon.

Olivier, let me know if there's anything else we can do to help with Conboy sync.

Both patches pushed, closing bug.