After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620100 - The shape extension is not used in gnome-screenshot
The shape extension is not used in gnome-screenshot
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: screenshot
trunk
Other Linux
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-30 15:14 UTC by Neil Roberts
Modified: 2010-07-16 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure: Check for shape.h if the xext is available instead of if not (1.26 KB, patch)
2010-05-30 15:17 UTC, Neil Roberts
committed Details | Review

Description Neil Roberts 2010-05-30 15:14:27 UTC
I think the configure script for gnome-screenshot is a bit broken so that it doesn't detect the shape extension correctly. Please see the attached patch.

I noticed this because all of the screenshots in a Linux magazine had ugly random colors at the corners of the window decorations. I bet this bug is to blame (in addition to lazy journalism..)
Comment 1 Neil Roberts 2010-05-30 15:17:30 UTC
Created attachment 162319 [details] [review]
configure: Check for shape.h if the xext is available instead of if not

Previously the configure script would only check for the shape.h
header if the xext pkg-config package is *not* available. This meant
that gnome-screenshot would only use the shape extension if the xext
package isn't installed which doesn't make much sense. Presumably the
intention was to check for the package and then check for the header
so that the shape extension is only used if both are available. This
patch fixes it to do that.
Comment 2 Emmanuele Bassi (:ebassi) 2010-07-16 15:21:37 UTC
Attachment 162319 [details] pushed as e43ad4d - configure: Check for shape.h if the xext is available instead of if not