After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620048 - Makefile's should use $(srcdir) instead of relative paths
Makefile's should use $(srcdir) instead of relative paths
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: general
0.7.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-29 21:17 UTC by Darren Warner
Modified: 2010-06-04 18:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update all Makefile.am's to use $(top_srcdir) (9.32 KB, patch)
2010-05-29 21:18 UTC, Darren Warner 		none Details | Review

Description Darren Warner 2010-05-29 21:17:34 UTC 
I'm creating this bug as a result of a build problem in Ubuntu (see https://bugs.launchpad.net/ubuntu/+source/vala/+bug/570908).

When using autoconf/automake-generated Makefile's, it is possible to run make while not in the current working directory of the source code being built. This means that custom build rules must use macros to locate sources rather than rely on relative paths.

Attached is a patch that fixes this problem.
Comment 1 Darren Warner 2010-05-29 21:18:16 UTC 
Created attachment 162281 [details] [review]
Update all Makefile.am's to use $(top_srcdir)
Comment 2 Jürg Billeter 2010-06-04 18:43:22 UTC 
commit baecbac8dfad95cebbbb6826d0db8cf77a714396
Author: Darren Warner <darren@dazwin.com>
Date:   Fri Jun 4 20:39:47 2010 +0200

    build: Use $(srcdir) instead of relative paths
    
    Fixes bug 620048.