GNOME Bugzilla – Bug 619920
Add more Properties in ImageTag
Last modified: 2010-06-14 14:32:53 UTC
This patches introduces some properties for common used stuff in ImageTag. Some others are reused from Audio/Video. Some implementations for the existing tags are also provided.
Created attachment 162183 [details] [review] JpegComment need not to be terminated by 0 Some programs set an jpeg comment which is not terminated by a 0. Therfore, we cannot remove the last character in every case. Rather, check for a terminated string.
Created attachment 162184 [details] [review] JpegComment need not to be terminated by 0 Some programs set an jpeg comment which is not terminated by a 0. Therfore, we cannot remove the last character in every case. Rather, check for a terminated string.
Created attachment 162185 [details] [review] Add some properties which are usefull for image tags The property Creator is added to ImageTag. The properties Copyright, Comment and Title are implemented in CombinedImageTag to reuse them from Audio/Video.
Created attachment 162186 [details] [review] Add more flexible PropertyModificationValidator The new class PropertyModificationValidator allows to test modifications for every property defined in ImageTag. This makes it more flexible to test them all.
Created attachment 162187 [details] [review] Add Test to ensure that the ImageTag properties work correctly
Created attachment 162188 [details] [review] Add Function which ensures that all possible image tags for an image file are in place
Created attachment 162189 [details] [review] Remove CommentTest for jpeg test without metadata It does not make sense to have that test here, because a comment cannot be added, when no tag is present. And it is against the current taglib policy to add tags without a request from the user.
Attachment 162184 [details] pushed as 19d9b41 - JpegComment need not to be terminated by 0 Attachment 162185 [details] pushed as f952828 - Add some properties which are usefull for image tags Attachment 162186 [details] pushed as 8e6071d - Add more flexible PropertyModificationValidator Attachment 162187 [details] pushed as 3d56b3e - Add Test to ensure that the ImageTag properties work correctly Attachment 162188 [details] pushed as 2906dac - Add Function which ensures that all possible image tags for an image file are in place Attachment 162189 [details] pushed as 514d270 - Remove CommentTest for jpeg test without metadata Great stuff, merged!