After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619897 - Fix leak of uri in soup_form_request_for_data()
Fix leak of uri in soup_form_request_for_data()
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other All
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2010-05-28 03:26 UTC by Jonathon Jongsma
Modified: 2010-05-28 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix leak of uri in soup_form_request_for_data() (713 bytes, patch)
2010-05-28 03:26 UTC, Jonathon Jongsma
committed Details | Review

Description Jonathon Jongsma 2010-05-28 03:26:02 UTC
Currently soup_form_request_for_data() seems to leak the uri.  This patch fixes
the leak.

Valgrind log:
==24835== 108 (64 direct, 44 indirect) bytes in 1 blocks are definitely lost in loss record 1,333 of 1,476
==24835==    at 0x4C221A7: malloc (vg_replace_malloc.c:195)
==24835==    by 0x612B504: g_malloc (gmem.c:132)
==24835==    by 0x6140409: g_slice_alloc (gslice.c:836)
==24835==    by 0x6140715: g_slice_alloc0 (gslice.c:845)
==24835==    by 0x5075021: soup_uri_new_with_base (soup-uri.c:177)
==24835==    by 0x5075AE1: soup_uri_new (soup-uri.c:401)
==24835==    by 0x505D6B7: soup_form_request_for_data (soup-form.c:357)
==24835==    by 0x4E2DFB5: prepare_message (rest-proxy-call.c:684)
==24835==    by 0x4E2E15C: rest_proxy_call_async (rest-proxy-call.c:737)
Comment 1 Jonathon Jongsma 2010-05-28 03:26:04 UTC
Created attachment 162165 [details] [review]
Fix leak of uri in soup_form_request_for_data()
Comment 2 Dan Winship 2010-05-28 10:54:13 UTC
Comment on attachment 162165 [details] [review]
Fix leak of uri in soup_form_request_for_data()

yup
Comment 3 Jonathon Jongsma 2010-05-28 16:53:05 UTC
Thanks, pushed to master.