After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619883 - Remove duplicate signal connected in totem-open-location
Remove duplicate signal connected in totem-open-location
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-05-27 22:03 UTC by Alexander Saprykin
Modified: 2010-05-28 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove duplicate signal connected in totem-open-location (2.72 KB, patch)
2010-05-27 22:03 UTC, Alexander Saprykin 		committed Details | Review

Description Alexander Saprykin 2010-05-27 22:03:16 UTC 
gtk_widget_destroy callback was connected twice to the "delete-event" signal of TotemOpenLocation object. This patch removes one in the totem_open_location_new() in totem-open-location.c. Also patch removes totem_open_location_destroy() in totem_object.c as this function destroys TotemOpenLocation object (totem->open_location) and sets it to NULL, but we already have weak reference to this object (added on object creation), so there is no need for this function. I replaced it with gtk_widget_destroy().
Comment 1 Alexander Saprykin 2010-05-27 22:03:18 UTC 
Created attachment 162151 [details] [review]
Remove duplicate signal connected in totem-open-location

Remove duplicate gtk_widget_destroy() callback for totem-open-location object in totem_open_location_new ()
Remove totem_open_location_destroy() in totem-object.c as we already have weak pointer to totem_open_location object