After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619824 - Use glib for checksumming
Use glib for checksumming
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.28
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-27 13:36 UTC by Bastien Nocera
Modified: 2010-06-02 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[avimux] clean up code for avi header using a bytewriter (24.21 KB, patch)
2010-05-27 14:08 UTC, Benjamin Otte (Company) 		rejected Details | Review
debugutils: Replace md5 implementation with glib's (13.21 KB, patch)
2010-05-27 14:09 UTC, Benjamin Otte (Company) 		committed Details | Review

Description Bastien Nocera 2010-05-27 13:36:04 UTC 
Found that gst-plugins-good-0.10.18/gst/debugutils/tests.c has its own md5 implementation.
Comment 1 Benjamin Otte (Company) 2010-05-27 14:08:53 UTC 
Created attachment 162103 [details] [review]
[avimux] clean up code for avi header using a bytewriter

https://bugzilla.gnome.org/show_bug.cgi?id=619293
Comment 2 Benjamin Otte (Company) 2010-05-27 14:09:23 UTC 
Created attachment 162104 [details] [review]
debugutils: Replace md5 implementation with glib's
Comment 3 Sebastian Dröge (slomo) 2010-05-27 14:37:39 UTC 
Comment on attachment 162104 [details] [review]
debugutils: Replace md5 implementation with glib's

Looks good, please push after freeze.
Comment 4 Sebastian Dröge (slomo) 2010-05-27 14:38:06 UTC 
...but maybe get rid of that md5_ wrapper thing completely :) It's not that useful
Comment 5 Benjamin Otte (Company) 2010-06-02 12:22:29 UTC 
commit 81c4dc4574c8891ef224c957a47f8781aca7a722
Author: Benjamin Otte <otte@redhat.com>
Date:   Thu May 27 16:07:31 2010 +0200

    debugutils: Replace md5 implementation with glib's