After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619776 - [x264enc] is unable to do Baseline with recent x264
[x264enc] is unable to do Baseline with recent x264
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal blocker
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 620233 627753 (view as bug list)
Depends on:
Blocks: 612338
 
 
Reported: 2010-05-27 03:26 UTC by Olivier Crête
Modified: 2010-08-23 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x264enc: Disable I weighted pred (1023 bytes, patch)
2010-05-27 03:26 UTC, Olivier Crête 		committed Details | Review
x264enc: Only set i_weighted_pred on versions where it exists (1.00 KB, patch)
2010-05-31 20:58 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2010-05-27 03:26:06 UTC 
Created attachment 162069 [details] [review]
x264enc: Disable I weighted pred

Recent versions of x264 have added a "i_weighted_pred" parameter. If it is not 0, it will set the profile to main. So that means that x264enc will never produce baseline streams. That causes interoperability issues with many decoders that only support baseline. Including the decoder on the N900 and the decoder that is used by Google Talk's video calling thing (bug #612338).

My simple solution for this release is to just disable that thing entirely (although I have no idea what it does, so I added Jason in CC). I guess it would be a better solution to fix bug #607798..
Comment 1 Jason Garrett-Glaser 2010-05-27 03:36:56 UTC 
As listed in the documentation, i_weighted_pred controls P-frame explicit weighted prediction.  Given that x264enc is already completely broken, it couldn't really hurt much to make it just a bit worse by forcing weighted prediction off.  But it would rather be better to fix the whole thing properly, as you mentioned.
Comment 2 Tim-Philipp Müller 2010-05-27 08:18:04 UTC 
We want to release today or tomorrow. I don't really want to drop in an untested x264enc rewrite at this point, even more so since it didn't really seem quite ready yet. So the less invasive any fix is, the better.
Comment 3 Tim-Philipp Müller 2010-05-28 11:19:19 UTC 
commit d6df52f99a82bc79d91aa229e379cfdf25c174d9
Author: Olivier Crête <tester@tester.ca>
Date:   Wed May 26 23:16:46 2010 -0400

    x264enc: disable I weighted pred
    
    If it is enabled, then it will be main profile instead of baseline.
    This ensures maximum compatibility of the output stream until the
    encoder configuration interface gets an overhaul with explicit
    output profile selection.
    
    Fixes #619776.
Comment 4 Olivier Crête 2010-05-31 20:58:38 UTC 
Created attachment 162406 [details] [review]
x264enc: Only set i_weighted_pred on versions where it exists

Arg, seems like we have to ifdev this on older versions...
Comment 5 Sebastian Dröge (slomo) 2010-06-01 09:15:46 UTC 
Comment on attachment 162406 [details] [review]
x264enc: Only set i_weighted_pred on versions where it exists

Yes, please push this :)
Comment 6 Sebastian Dröge (slomo) 2010-06-01 09:16:57 UTC 
*** Bug 620233 has been marked as a duplicate of this bug. ***
Comment 7 Tim-Philipp Müller 2010-06-25 18:26:22 UTC 
This was pushed at some point..
Comment 8 Sebastian Dröge (slomo) 2010-08-23 19:10:21 UTC 
*** Bug 627753 has been marked as a duplicate of this bug. ***