After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619702 - configure script not compatible with dash as /bin/sh
configure script not compatible with dash as /bin/sh
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.30.x
Other Linux
: Normal minor
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-26 10:16 UTC by Simon McVittie
Modified: 2010-05-26 10:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch 1/2 (1.33 KB, patch)
2010-05-26 10:17 UTC, Simon McVittie 		committed Details | Review
patch 2/2 (1.31 KB, patch)
2010-05-26 10:17 UTC, Simon McVittie 		committed Details | Review

Description Simon McVittie 2010-05-26 10:16:31 UTC 
Empathy's configure script has some incompatibilities with non-bash shells.

test foo -a bar isn't portable: use test foo && test bar.
test foo -o bar isn't portable: use test foo || test bar.
test foo == bar isn't portable: use test foo = bar.

with-session-bus.sh also has a portability bug (use of &>) which was already fixed in telepathy-glib.

Patch for master:
http://git.collabora.co.uk/?p=user/smcv/empathy.git;a=shortlog;h=refs/heads/trivia

Trivial backport to 2.30:
http://git.collabora.co.uk/?p=user/smcv/empathy.git;a=shortlog;h=refs/heads/2.30-trivia
Comment 1 Simon McVittie 2010-05-26 10:17:08 UTC 
Created attachment 162000 [details] [review]
patch 1/2
Comment 2 Simon McVittie 2010-05-26 10:17:20 UTC 
Created attachment 162001 [details] [review]
patch 2/2
Comment 3 Guillaume Desmottes 2010-05-26 10:29:16 UTC 
Thanks, merged to both branches.

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.