After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619693 - Top panel is hidden in Overview if active window is in full screen mode
Top panel is hidden in Overview if active window is in full screen mode
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-26 07:50 UTC by Tanner Doshier
Modified: 2010-05-26 20:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Always display panel in the overview (1.37 KB, patch)
2010-05-26 19:10 UTC, drago01
rejected Details | Review
[chrome] Ignore fullscreen flag when in overview (1.18 KB, patch)
2010-05-26 20:02 UTC, drago01
committed Details | Review

Description Tanner Doshier 2010-05-26 07:50:54 UTC
If you make the active window full screen and then enter the Overview, the top panel (or top menubar, whatever we are calling it) does not appear. If you switch to a workspace (or app) whose active window is not in full screen mode the panel appears in the Overview immediately.


To reproduce (in 2.29.1 from the ricotz ppa):

 (1) Make active window full screen, typically F11

 (2) Activate the Activities Overview using the keyboard (because full screen       also blocks the hot corner functionality)


I assume this is because on the workspace the panel is not shown and that state persists when you enter the Overview for some reason. 

The panel should always be visible in the Overview.
Comment 1 drago01 2010-05-26 19:10:56 UTC
Created attachment 162042 [details] [review]
Always display panel in the overview

When going from a fullscreen app to the overview (by pressing super),
the panel is invisible because we belive that we are still in fullscreen.
Comment 2 Dan Winship 2010-05-26 19:49:11 UTC
Comment on attachment 162042 [details] [review]
Always display panel in the overview

>+        // We have to check whether we are in fullscreen in order
>+        // to decide the visibility of the chrome

the entire reason for having separate inOverview and inFullscreen flags was so that we wouldn't have to do this.

Rather than faking out inFullscreen, you should just fix _updateVisibility() to ignore it if inOverview is true.
Comment 3 drago01 2010-05-26 20:02:21 UTC
Created attachment 162045 [details] [review]
[chrome] Ignore fullscreen flag when in overview

Ignore the fullscreen flag when we are in the overview,
otherwise we might up not showing actors like the panel even though
they have visibleInOverview set to true.
Comment 4 drago01 2010-05-26 20:14:46 UTC
Attachment 162045 [details] pushed as 77fcf68 - [chrome] Ignore fullscreen flag when in overview