GNOME Bugzilla – Bug 619648
Orca doesn't speak list bullets and numbers which were automatically inserted by OOo Writer
Last modified: 2010-09-20 10:53:45 UTC
When typing in openoffice writer, if you do something which makes openoffice do an autocompletion (autocorrection I think may also apply) orca will not speak the automatically inserted text. Steps to reproduce: 1. type the following line in openoffice writer and press enter: (I) Hello world Openoffice will automatically insert a (II) on the second line when you pressed the enter. Expected result: Orca will echo the insertion Actual: Orca says nothing when the insertion happens. Extra notes: I have orca set to echo by word and the above is what I expect for my settings, I don't know whether other users of other settings (eg. character echo) would want exactly what I say I want to here. Should orca note that it is autocompletion/autoinsertion/autocorrection?
Thanks for filing this, Michael! This should be pretty straightforward. I'll try to have something for consideration soon.
Turns out we're not getting a text-inserted event for this. But that's another matter. I'm pretty sure I can still uniquely catch this situation. Note that I'm re-summarizing this. There are various sorts of automatically inserted text and they are different beasts requiring different fixes and may have different associated desired behaviors and possibly settings. Let's open new bugs for each as is appropriate. Regarding the automatic insertion of list bullets and numbers. My personal thoughts and questions are: 1. We should not say anything to indicate that it's an autoinsertion. Normally pressing Return in a Writer document places you an a new, *empty* paragraph. If we present the list number or bullet that appears when you press Return, I'd think that would be sufficient information to clue you into the fact that some automatic text insertion just took place. 2. Do we need a setting for this? In other words, is there anyone who would find the presentation of the bullet or list number objectionable because of course it was inserted because they're in a list and why is Orca being so chatty? :-) I suppose these are questions for the Orca list. So I'll ask.
Created attachment 162286 [details] [review] proposed patch - take 1 This works for me. Please test. Thanks!
Note that in the case of bullets, this is part Orca and part speech synthesizer. For instance, it works as expected with espeak in OpenSolaris. However, when I try this patch on Linux Mint (based on Ubuntu) which is using Speech Dispatcher, I hear the numbers spoken, but not the bullets. But if I look in my debug.out, I see SPEECH OUTPUT lines for the bullets, just like I do the numbers. In addition, if I arrow Up and Down amongst the bulleted lines with Speech Dispatcher, they are not pronounced; but with espeak they are. Getting a speech synthesizer to treat the bullets differently than they currently do is something that should be addressed... somewhere. But it's not part of this bug.
I think since the bullets aren't being spoken by speech dispatcher, and that is an integral part of this bug/enhancement, I think the fix should go here. Just my thought. I hope the fix is easy enough:).
(In reply to comment #5) > I think since the bullets aren't being spoken by speech dispatcher, and that is > an integral part of this bug/enhancement, I think the fix should go here. Just > my thought. I hope the fix is easy enough:). Even without this patch, if you arrow Up and Down amongst items in a bulleted list, the bullets are not being spoken. It's a separate bug.
I've opened bug 620109 for the problem of bullets not being spoken as you arrow Up and Down. Michael, have you had the opportunity to try this patch? Thanks!
I just got through testing the patch while using Open Office Writer version 3.2 from the normal Arch Linux production package repository and numbers speak fine. I made some interesting observations concerning bullets but will continue that part on But #620109. But as far as this patch is concerned, good with version 3.2 of Writer.
I have just tried the patch and it seems to work fine.
Comment on attachment 162286 [details] [review] proposed patch - take 1 http://git.gnome.org/browse/orca/commit/?id=a60e9deb161aa5b95c845c583379b21c26204657
Thanks guys! I did additional manual testing in 3.1, 3.2, and 3.3. And ran the regression tests on it. Between that and your findings, I've gone ahead and committed it to master. If it later turns out that folks do want a setting for this, we can always open a new RFE for it.