After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619642 - The default MP3 profile is broken
The default MP3 profile is broken
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: media profiles
2.30.x
Other Linux
: Normal major
: ---
Assigned To: gnome media maintainers
gnome media maintainers
: 626286 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-05-25 17:35 UTC by Pascal de Bruijn
Modified: 2010-09-28 01:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change default to lamemp3enc encoding plugin (1.67 KB, patch)
2010-05-25 17:35 UTC, Pascal de Bruijn
committed Details | Review

Description Pascal de Bruijn 2010-05-25 17:35:58 UTC
Created attachment 161964 [details] [review]
Change default to lamemp3enc encoding plugin

By default the "CD Quality, MP3" profile is broken.

It seems to encode to 128kbit CBR, while it intends to encode to VBR Quality 6. Changing the VBR Quality has no effect at all.

I was told the 'lame' encoding plugin has been deprecated, and it's being replaced by 'lamemp3enc'.

I attached a patch which changes the default, including the adding of a xing header. This will make sure Totem and others will properly display the file's bitrate and length.

I hope this can be fixed for 2.30.1?
Comment 1 Pascal de Bruijn 2010-05-25 17:39:16 UTC
Small note, the attached patch is intended for a release tarball. So for upstream commit only the .in file needs to be modified I guess.
Comment 2 Sebastian Dröge (slomo) 2010-05-26 09:18:15 UTC
Yes, lame was deprecated by lamemp3enc and should always be used instead of lame (because of the broken interface and quality problems caused by this).
Comment 3 Bastien Nocera 2010-05-26 09:32:16 UTC
When was lamemp3enc added?
Comment 4 Sebastian Dröge (slomo) 2010-05-26 10:25:09 UTC
gst-plugins-ugly 0.10.12
Comment 5 Bastien Nocera 2010-05-26 10:49:20 UTC
Comment on attachment 161964 [details] [review]
Change default to lamemp3enc encoding plugin

Feel free to commit to 2.30.x and master
Comment 6 Sebastian Dröge (slomo) 2010-05-29 05:57:27 UTC
commit 155f6ce6463a95146664b08b924d057679ca2f7c
Author: Pascal de Bruijn <pmjdebruijn@pcode.nl>
Date:   Sat May 29 07:54:58 2010 +0200

    profiles: Use lamemp3enc and xingmux instead of the deprecated lame element
    
    The lame element has a broken interface and results in worse
    quality encodings. The xingmux element is added to allow correct
    duration reporting and seeking for VBR files.
    
    Fixes bug #619642.



commit d81e10b63f5a38a5004ff2486e679608cb7dbab9
Author: Pascal de Bruijn <pmjdebruijn@pcode.nl>
Date:   Sat May 29 07:54:58 2010 +0200

    profiles: Use lamemp3enc and xingmux instead of the deprecated lame element
    
    The lame element has a broken interface and results in worse
    quality encodings. The xingmux element is added to allow correct
    duration reporting and seeking for VBR files.
    
    Fixes bug #619642.
Comment 7 Jonathan Matthew 2010-08-07 00:02:00 UTC
*** Bug 626286 has been marked as a duplicate of this bug. ***
Comment 8 Kenno 2010-09-26 22:44:23 UTC
I still have a small issue with the patch. quality=6 is far from CD quality; people with undamaged ears can easily hear the difference given a good enough listening environment. I would suggest setting quality=2 for the "CD quality" option. This produces significantly higher bitrates, so for users that are concerned about file size, you might want to introduce a new "portable MP3 player" option that sets quality=6. Lastly, here's the hydrogenadio suggested setting for "Voice quality": lamemp3enc name=enc target=1 bitrate=56 mono=true

For more info, see
http://wiki.hydrogenaudio.org/index.php?title=Lame#Recommended_encoder_settings
https://bugs.launchpad.net/ubuntu/+source/sound-juicer/+bug/195483/comments/52
Comment 9 Kenno 2010-09-28 01:48:03 UTC
On second thought, this might go a bit beyond the scope of the current bug, so I filed it as a new one:
https://bugzilla.gnome.org/show_bug.cgi?id=630779