GNOME Bugzilla – Bug 619606
only force to implement virtual methods that are tagged as GI_VFUNC_MUST_OVERRIDE
Last modified: 2010-12-08 17:24:40 UTC
As returned by g_vfunc_info_get_flags
Created attachment 173439 [details] [review]
implement VFuncInfo.must_override to determine if a vfunc needs to be overridden
In reality this isn't supported by gi and they debated changing it in gi. Better fix is to not complain when overrides do not error out.
(In reply to comment #2)
> In reality this isn't supported by gi and they debated changing it in gi.
> Better fix is to not complain when overrides do not error out.
Do we have a ticket about removing that check?
I just checked in a better fix which came with the recursive vfunc patch. We now do not error out in overrides since you might want to override a class but not implement all of its vfuncs. It only errors out when subclassing if the vfunc pointer is NULL. This still may break if there are vfuncs you are allowed to keep unset but I'm not aware if that is the case for any classes.