After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619594 - jp2k: add debug-level property
jp2k: add debug-level property
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-25 11:23 UTC by Andy Wingo
Modified: 2012-10-21 21:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
jp2k: use gst_element_class_set_details_simple (2.70 KB, patch)
2010-05-25 11:24 UTC, Andy Wingo 		rejected Details | Review
jp2k: add debug-level property (2.09 KB, patch)
2010-05-25 11:24 UTC, Andy Wingo 		needs-work Details | Review

Description Andy Wingo 2010-05-25 11:23:32 UTC 
Find attached a couple of patches to jasper, to fix some element details usage and to add a debug-level property.
Comment 1 Andy Wingo 2010-05-25 11:24:32 UTC 
Created attachment 161928 [details] [review]
jp2k: use gst_element_class_set_details_simple
Comment 2 Andy Wingo 2010-05-25 11:24:53 UTC 
Created attachment 161929 [details] [review]
jp2k: add debug-level property
Comment 3 Benjamin Otte (Company) 2010-05-25 11:44:37 UTC 
(In reply to comment #2)
> Created an attachment (id=161929) [details] [review]
> jp2k: add debug-level property

Shouldn't this be set in plugin_init() according to a GStreamer debug category?
It seems it's a global and not a per-plugin setting.
Comment 4 Andy Wingo 2010-05-25 15:53:47 UTC 
Possibly; but gstreamer debug levels are settable at runtime, not just from env vars, and we don't get any callbacks when they change. Easiest to do it this way IMO, though I don't particularly care :)
Comment 5 Sebastian Dröge (slomo) 2011-05-09 09:25:30 UTC 
Comment on attachment 161928 [details] [review]
jp2k: use gst_element_class_set_details_simple

This was already changed some time ago
Comment 6 Sebastian Dröge (slomo) 2011-05-09 09:26:36 UTC 
Comment on attachment 161929 [details] [review]
jp2k: add debug-level property

I have to agree, this should be done in plugin_init() based on the GStreamer debug level. Also having a property on an instance that changes a global setting is wrong.

Do you want to provide a new patch, is there still the need for this?
Comment 7 Andy Wingo 2011-05-09 09:45:57 UTC 
I don't work on J2K any more.  Do what you want with this :-)
Comment 8 Tim-Philipp Müller 2012-10-21 21:48:04 UTC 
Let's just close it then ;-)