GNOME Bugzilla – Bug 619583
add audio player detection to gdu/udisks2 volume monitor
Last modified: 2014-03-10 12:10:02 UTC
Created attachment 161917 [details] [review] patch The gdu volume monitor currently doesn't identify audio player devices. It can use the ID_MEDIA_PLAYER udev property that media-player-info's udev rules set to do this.
Created attachment 161918 [details] [review] patch fixed some missing #ifdefs around the added code
Looks good to me.
Created attachment 225845 [details] [review] udisks2: Add appropriate content type for media players I just noticed that since we switched from the gdu to the udisks2 backend, media players were not recognized as such by gvfs/nautilus any more (for the gdu backend we had a kludge patch). As it's been decided that udisks2 itself should not know about media players (https://bugs.freedesktop.org/show_bug.cgi?id=24500), querying the udev property directly is the right thing. Simple and tested patch attached.
Looks good to me and thanks for your attention to detail - it's appreciated! Please commit to master and cherry-pick to the gnome-3-6 branch!
Comment on attachment 225845 [details] [review] udisks2: Add appropriate content type for media players Committed udisks2 patch to both master and gnome-3-6, thanks for the quick review! I'll leave the bug open since technically I hijacked it a bit (it originally was against the gdu backend).
This broke at least in Ubuntu for pretty much every release. I added a test case for this to the gvfs test suite now (see https://mail.gnome.org/archives/gvfs-list/2012-August/msg00000.html)
At this point it is pretty much a wontfix for the gdu backend, and for udisks this was committed ages ago, so closing.