GNOME Bugzilla – Bug 619542
[WIP] Associate XSMP clients with applications, use it to implement Quit
Last modified: 2018-07-13 19:44:52 UTC
This doesn't quite give the effect we want yet for Firefox at least; we may need to try a SaveYourself request. Stashing this in bugzilla until I can come back to it.
Created attachment 161890 [details] [review] Associate process identifiers with applications Cache the set of pids for an application, in preparation for landing an XSMP patch which requires this information.
Created attachment 161891 [details] [review] Associate XSMP clients with applications, use it to implement Quit If a process makes an XSMP connection, attempt to associate that with an application. If we're successful, we can request that an application terminate via XSMP.
(In reply to comment #0) > This doesn't quite give the effect we want yet for Firefox at least what's the desired effect and what's the effect you get? unfortunately, the general rule with XSMP is that the interoperable subset is exactly the functionality we're already using, and no more. So if you're trying to do something new, it probably won't work on 50% of clients.
Well, I guess the effect we want is the exact same result from doing File->Quit fom the menu. But Firefox just seems to take SmsDie as "kill myself immediately, don't save anything, don't show session restore dialog on startup" which is decidedly suboptimal. I need to rework the patch so that we request interaction with the apps, but this requires more gnome-session work.
Created attachment 162977 [details] [review] Associate process identifiers with applications Cache the set of pids for an application, in preparation for landing an XSMP patch which requires this information.
Review of attachment 162977 [details] [review]: Looks like a nice cleanup. One catch, should be good to commit after fixing. ::: src/shell-window-tracker.c @@ +773,3 @@ + + GSList *pids = shell_app_get_pids (app); + ShellApp *app = iter->data; Shouldn't that be pids?
Comment on attachment 162977 [details] [review] Associate process identifiers with applications Attachment 162977 [details] pushed as bf6d0dc - Associate process identifiers with applications
Comment on attachment 161891 [details] [review] Associate XSMP clients with applications, use it to implement Quit Marking needs-work, since it sounds like we aren't immediately going with this approach, though the subject may need revisiting in the future.
Is this going to be relevant with the new app menu cleanups?
Relying on XSMP without corresponding wayland functionality isn't a good idea at this point, plus the app menu is likely going away.