After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619542 - [WIP] Associate XSMP clients with applications, use it to implement Quit
[WIP] Associate XSMP clients with applications, use it to implement Quit
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-24 18:32 UTC by Colin Walters
Modified: 2018-07-13 19:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Associate process identifiers with applications (5.83 KB, patch)
2010-05-24 18:32 UTC, Colin Walters
none Details | Review
Associate XSMP clients with applications, use it to implement Quit (13.43 KB, patch)
2010-05-24 18:33 UTC, Colin Walters
needs-work Details | Review
Associate process identifiers with applications (3.88 KB, patch)
2010-06-07 21:17 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2010-05-24 18:32:43 UTC
This doesn't quite give the effect we want yet for Firefox at least; we
may need to try a SaveYourself request. 

Stashing this in bugzilla until I can come back to it.
Comment 1 Colin Walters 2010-05-24 18:32:56 UTC
Created attachment 161890 [details] [review]
Associate process identifiers with applications

Cache the set of pids for an application, in preparation for
landing an XSMP patch which requires this information.
Comment 2 Colin Walters 2010-05-24 18:33:00 UTC
Created attachment 161891 [details] [review]
Associate XSMP clients with applications, use it to implement Quit

If a process makes an XSMP connection, attempt to associate that
with an application.  If we're successful, we can request that
an application terminate via XSMP.
Comment 3 Dan Winship 2010-05-25 13:19:32 UTC
(In reply to comment #0)
> This doesn't quite give the effect we want yet for Firefox at least

what's the desired effect and what's the effect you get?

unfortunately, the general rule with XSMP is that the interoperable subset is exactly the functionality we're already using, and no more. So if you're trying to do something new, it probably won't work on 50% of clients.
Comment 4 Colin Walters 2010-05-25 14:53:06 UTC
Well, I guess the effect we want is the exact same result from doing File->Quit fom the menu.  But Firefox just seems to take SmsDie as "kill myself immediately, don't save anything, don't show session restore dialog on startup" which is decidedly suboptimal.

I need to rework the patch so that we request interaction with the apps, but this requires more gnome-session work.
Comment 5 Colin Walters 2010-06-07 21:17:13 UTC
Created attachment 162977 [details] [review]
Associate process identifiers with applications

Cache the set of pids for an application, in preparation for
landing an XSMP patch which requires this information.
Comment 6 Florian Müllner 2010-06-07 21:47:31 UTC
Review of attachment 162977 [details] [review]:

Looks like a nice cleanup. One catch, should be good to commit after fixing.

::: src/shell-window-tracker.c
@@ +773,3 @@
+
+      GSList *pids = shell_app_get_pids (app);
+      ShellApp *app = iter->data;

Shouldn't that be pids?
Comment 7 Colin Walters 2010-06-09 18:43:59 UTC
Comment on attachment 162977 [details] [review]
Associate process identifiers with applications

Attachment 162977 [details] pushed as bf6d0dc - Associate process identifiers with applications
Comment 8 Owen Taylor 2010-06-15 19:54:07 UTC
Comment on attachment 161891 [details] [review]
Associate XSMP clients with applications, use it to implement Quit

Marking needs-work, since it sounds like we aren't immediately going with this approach, though the subject may need revisiting in the future.
Comment 9 Jasper St. Pierre (not reading bugmail) 2011-12-04 20:23:35 UTC
Is this going to be relevant with the new app menu cleanups?
Comment 10 Florian Müllner 2018-07-13 19:44:52 UTC
Relying on XSMP without corresponding wayland functionality isn't a good idea at this point, plus the app menu is likely going away.