GNOME Bugzilla – Bug 619521
[perf] replace frame count with accurately computed frame rate
Last modified: 2010-05-26 19:39:19 UTC
Compute a frame rate for the period between: - User sees first frame of overview animation - User sees fully zoomed-out overview And replace the current Frames count metrics with this. The previous frame count metrics were actually over the period from the start of the animation until the window labels finished animating in; here we are careful to look at a more restricted period.
Created attachment 161868 [details] [review] [perf] replace frame count with accurately computed frame rate
Review of attachment 161868 [details] [review]: Looks good and the numbers reported look sane. ::: js/perf/core.js @@ +17,1 @@ units: "frames" }, Well fps means "frames per second" so the units should be that and not "frames". @@ +23,1 @@ units: "us" }, "us" is even worse than "frames" ;) @@ +121,3 @@ +} + +function glx_swapComplete(time, swapTime) { Am I right to assume that this depends on #619516 ?
(In reply to comment #2) > Review of attachment 161868 [details] [review]: > > Looks good and the numbers reported look sane. > > ::: js/perf/core.js > @@ +17,1 @@ > units: "frames" }, > > Well fps means "frames per second" so the units should be that and not > "frames". Yeah, it should be "frames / s" - good catch. > @@ +23,1 @@ > units: "us" }, > > "us" is even worse than "frames" ;) Yep. > @@ +121,3 @@ > +} > + > +function glx_swapComplete(time, swapTime) { > > Am I right to assume that this depends on #619516 ? Yes, it does. (Well, not a hard dep since there's a fallback since systems may not report glx.swapComplete, but conceptually it does, and it does to get the best numbers.)
Attachment 161868 [details] pushed as 15dd116 - [perf] replace frame count with accurately computed frame rate