After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619488 - EmpathyTpContactFactort should be killed
EmpathyTpContactFactort should be killed
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 579812 616603
Blocks:
 
 
Reported: 2010-05-24 08:31 UTC by Xavier Claessens
Modified: 2010-05-26 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Xavier Claessens 2010-05-24 08:31:33 UTC 
All features of that object are now part of TpContact (starting from tp-glib 0.11.6 which is not yet released).
Comment 1 Xavier Claessens 2010-05-24 08:35:42 UTC 
Here is a branch doing this:
http://git.collabora.co.uk/?p=user/xclaesse/empathy.git;a=shortlog;h=refs/heads/kill-factory

It keeps some API as helper function, waiting for the TpConnection API to be revisited, see fd.o bug https://bugs.freedesktop.org/show_bug.cgi?id=27687
Comment 2 Xavier Claessens 2010-05-24 08:36:45 UTC 
Have to first fix bug #616603 and bug #579812
Comment 3 Guillaume Desmottes 2010-05-26 09:20:42 UTC 
+/* TpContact* -> EmpathyContact* */
say if they are reffed or borrowed

empathy_tp_contact_factory_set_alias ()
Any reason to not have this API on the EmpathyContact object?
Comment 4 Xavier Claessens 2010-05-26 09:25:20 UTC 
(In reply to comment #3)
> +/* TpContact* -> EmpathyContact* */
> say if they are reffed or borrowed

It is borrowed, see comment when inserting in the table... but I'll make it clear there too.

> empathy_tp_contact_factory_set_alias ()
> Any reason to not have this API on the EmpathyContact object?

I actually have a branch to make it on TpContact, but got smcv-complications... https://bugs.freedesktop.org/show_bug.cgi?id=28037
So I didn't bothered moving the code in empathy, but I could do that now, right.
Comment 5 Xavier Claessens 2010-05-26 09:35:16 UTC 
fixes pushed in the branch.
Comment 6 Guillaume Desmottes 2010-05-26 09:38:07 UTC 
Looks good, please merge.
Comment 7 Xavier Claessens 2010-05-26 09:40:37 UTC 
merged in empathy master, thanks :)