GNOME Bugzilla – Bug 619486
Orca does not give feedback when performing an incremental find in eclipse
Last modified: 2010-09-20 10:53:49 UTC
Eclipse has a feature called incremental find in which the user types part of a text and Eclipse jumps to first line where the text exists. The find runs as the user types the text but Orca currently provides no feedback as the user types Since Eclipse jumps to the line where the text was found, it is interesting that the orca read that line.
Created attachment 161839 [details] [review] revision 1
Comment on attachment 161839 [details] [review] revision 1 Interesting. If I'm reading what you're saying correctly, this problem isn't as big of a problem as it looked to me when you asked about it on the list. Nice work, José! Question: What happens if instead of typing, the user: * copied and pasted text * did a select all * cut several lines of text and then did an undo * did anything else to move the caret more than 1 offset ? Nits: * The purpose of script_utilites.py is to contain methods needed to find objects, compare objects, manipulate strings, etc., etc. The scripts themselves should deal with processing and reacting to events, including storing whatever data is needed for that purpose. Thus your movement keys should be in script.py (in __init__()); not in script_utilities.py. * Within a list, you don't need a '\' to continue onto the next line. * Please ensure that your lines are no more than 80 characters long -- that goes for comments as well as code -- and do not contain trailing whitespace. If you fix the above, don't have any issues with tasks like copying and pasting, and have tested all of the functionality you've already implemented in this script to be sure it continues to work when navigating, when typing (including with various key echoes), when debugging, and when doing an incremental find, I'll commit your changes.
Created attachment 161907 [details] [review] revision 2 I'll test tomorrow on my job
(In reply to comment #2) > > Question: What happens if instead of typing, the user: > > * copied and pasted tex an object:text-changed:insert and an object:text-caret-moved are received by orca. The text inserted is spoken in the function onTextInserted and the new line to where the cursor was, is spoken in the function _presentTextAtNewCaretPosition. My new patch attempts to prevent the function _presentTextAtNewCaretPosition is processed when a text is inserted. > * did a select all > * cut several lines of text and then did an undo After the cut orca speaks the new line in which the cursor is positioned. After the undo the new text is spoken. > * did anything else to move the caret more than 1 offset If the caret is moved with up/down/home/end/etc, no problems because it is processed in the default script. I'll do more tests on my job and I'll report the results. Time to sleep! Thanks.
(In reply to comment #3) > Created an attachment (id=161907) [details] [review] > revision 2 > > I'll test tomorrow on my job I used the eclipse for most of the day without any problem. I found more problems, but not because of the patch.
(In reply to comment #5) > (In reply to comment #3) > > Created an attachment (id=161907) [details] [review] [details] [review] > > revision 2 > > > > I'll test tomorrow on my job > I used the eclipse for most of the day without any problem. > I found more problems, but not because of the patch. So is this patch ready to commit?
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #3) > > > Created an attachment (id=161907) [details] [review] [details] [review] [details] [review] > > > revision 2 > > > > > > I'll test tomorrow on my job > > I used the eclipse for most of the day without any problem. > > I found more problems, but not because of the patch. > > So is this patch ready to commit? Yes. Sorry, I forgot to say that it is ready to commit. Thanks.
No worries. I just wanted to be sure. Committed to master. http://git.gnome.org/browse/orca/commit/?id=dd4d2c632972cc2cd70b4391f2599f4668720296 If the incremental find issue has been completely addressed, feel free to close out this bug as FIXED. Thanks!