After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619483 - basevideodecoder: init QoS proportion to 1.0
basevideodecoder: init QoS proportion to 1.0
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-24 07:25 UTC by Philip Jägenstedt
Modified: 2010-05-26 11:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.46 KB, patch)
2010-05-24 07:25 UTC, Philip Jägenstedt
rejected Details | Review

Description Philip Jägenstedt 2010-05-24 07:25:02 UTC
Created attachment 161828 [details] [review]
patch

Proportion isn't used by vp8dec (yet?), but 0.5 "indicates that the upstream element is producing data faster than real-time", which doesn't seem like the correct default.
Comment 1 Sebastian Dröge (slomo) 2010-05-24 07:45:44 UTC
Yes, 0.5 doesn't look correct but is used as default by other elements too. So if we're going to change it here we should change it elsewhere too.
Comment 2 Sebastian Dröge (slomo) 2010-05-24 08:34:14 UTC
Other elements using 0.5 are:

jp2kdec, jpegdec, shapewipe, deinterlace, videomixer, ffdec_*

But all of these are not using the proportion either.
Comment 3 Benjamin Otte (Company) 2010-05-24 10:11:24 UTC
Why do we have properties that don't work?
Comment 4 Sebastian Dröge (slomo) 2010-05-24 10:42:45 UTC
(In reply to comment #3)
> Why do we have properties that don't work?

Hm? They're values from the QoS events, that could be used by elements to change their behaviour. If the proportion is bad you could switch to a worse but faster algorithm for example. If the time is ahead you can as well drop frames. These are not properties or anything, some elements just parse and store them for completeness or future use.
Comment 5 Wim Taymans 2010-05-26 09:21:37 UTC
The thing is that a value of 1.0 means that the decoder is operating at exactly the right speed to make things still work realtime. What you usually want is a value much less than 1.0 so that you have planty of CPU headroom. Some decoders, for example, start dropping frames when they get close to 1.0. So, 0.5 is a safer value, I guess.
Comment 6 Sebastian Dröge (slomo) 2010-05-26 11:32:35 UTC
Let's close this as NOTABUG then.