After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619456 - Change to pango_fc_font_create_base_metrics_for_context so that gmake check passes
Change to pango_fc_font_create_base_metrics_for_context so that gmake check p...
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-23 19:52 UTC by David Shao
Modified: 2010-06-04 06:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] pango_fc_font_create_base_metrics_for_context in pangoft2.def (435 bytes, patch)
2010-05-23 19:52 UTC, David Shao
none Details | Review

Description David Shao 2010-05-23 19:52:55 UTC
Created attachment 161812 [details] [review]
[PATCH] pango_fc_font_create_base_metrics_for_context in pangoft2.def

Overview:

API change fc_font_create_metrics_for_context() to
fc_font_create_base_metrics_for_context() is not recorded in latest pango git
pango/pangoft2.def so that gmake check fails.

Steps to reproduce:

Build latest git pango and run (g)make check

Actual Results:

    Checking ./pangoft2.def
    --- pangoft2.list	2010-05-23 12:24:41 -0700
    +++ pangoft2.expected	2010-05-23 12:24:41 -0700
    @@ -1,7 +1,7 @@
     pango_fc_decoder_get_charset
     pango_fc_decoder_get_glyph
     pango_fc_decoder_get_type
    -pango_fc_font_create_metrics_for_context
    +pango_fc_font_create_base_metrics_for_context

Expected Results:

Amazingly on DragonFly BSD with attached patch,

    All tests passed.
    PASS: runtests.sh
    =============
    1 test passed
    =============

Build Date and Platform:

Pango git last commit
commit 495932623fb3390dd4249e08a3fd8593ebceaef4

DragonFly  2.7-DEVELOPMENT DragonFly v2.7.3.60.g795da1-DEVELOPMENT #46: Thu May 20 15:37:15 PDT 2010     root@:/usr/obj/usr/src/sys/X86_64_GENERIC  x86_64

Additional Information:

One line change to pango/pangoft2.def, patch attached
Comment 1 Behdad Esfahbod 2010-06-04 06:09:44 UTC
Matthias fixed this in master.