GNOME Bugzilla – Bug 619432
TagLib# does not support GIF files
Last modified: 2010-06-19 14:54:54 UTC
This patches introduces GIF support to TagLib#
Created attachment 161778 [details] [review] Extend Validators to specify an own comment string for the test The current implementation of CommentModificationValidator and TagCommentModificationValidator uses a fixed comment for testing. This commit extends the Validators that the comment string can be changed and an arbitrary comment can be used for the test.
Created attachment 161779 [details] [review] Add Validator to test removal of tags from files A new Validator for the image tests is added which can be used to test if tags are correctly removed from files.
Created attachment 161781 [details] [review] Add tests for GIF support This commit adds a bunch of tests for the GIF support. The sample files are created with GIMP and modified with exiftool. Some sample files are hand-edited to provide input data for some special tests.
Created attachment 161782 [details] [review] Introduce support for GIF files One Commit got lost.
Created attachment 161783 [details] [review] Introduce support for GIF files This commit introduces support for GIF files. A GIF file is parsed completely and XMP metadata and GIF comments are extracted. Additionally, the size of the image is extracted. Since GIF files can be used as an animation, it would be reasonable to determine some Properties which are related to Audio/Video files. This is currently not covered.
Created attachment 161784 [details] [review] Extend Validators to specify an own comment string for the test The current implementation of CommentModificationValidator and TagCommentModificationValidator uses a fixed comment for testing. This commit extends the Validators that the comment string can be changed and an arbitrary comment can be used for the test.
Created attachment 161785 [details] [review] Add Validator to test removal of tags from files A new Validator for the image tests is added which can be used to test if tags are correctly removed from files.
Created attachment 161786 [details] [review] Add tests for GIF support This commit adds a bunch of tests for the GIF support. The sample files are created with GIMP and modified with exiftool. Some sample files are hand-edited to provide input data for some special tests.
Review of attachment 161783 [details] [review]: Very clean patch. Am not going to pretend I know the details of GIF to say if it's correct or not, but the tests you supplied give me confidence. Extremely good stuff Mike, this is going in! ::: src/TagLib/Gif/File.cs @@ +396,3 @@ + case 0x3B: + return; + break; This line is unreachable. But don't worry about it, I added a commit to fix it.
Attachment 161783 [details] pushed as be86da1 - Introduce support for GIF files Attachment 161784 [details] pushed as 52399c3 - Extend Validators to specify an own comment string for the test Attachment 161785 [details] pushed as 05da6a1 - Add Validator to test removal of tags from files Attachment 161786 [details] pushed as 065c3d8 - Add tests for GIF support