GNOME Bugzilla – Bug 619332
generators should filter out '\r' line endings.
Last modified: 2010-09-20 10:53:50 UTC
This causes a problem for us in orca since we would get something like this: currentLineText=['package main;\r'] Thanks to Jose for providing debug file: http://bugzilla-attachments.gnome.org/attachment.cgi?id=161680 (Please search for \r' in that file to see examples.) With speech-dispatcher and espeak, \r seems to be silently ignored, which prevents the standard 'blank line' check to fail. I dont have eclipse installed, but i would imagine the \r is showing up on the braille display as an unrecognized symbol. alternatives: 1. We ask the nice people of Eclipse to detect when they are running on linux, and provide \n line endings. Nothing further with orca is needed. 2. we overwride some of the generator functions for eclipse and let those generators filter the \r before returning. (Disadvantage, we might not know all the generators that need modification). -Jon
This can be easily reproduced by performing the following steps: 1. create a new project using eclipse. 2. In the package explorer select the new project created in the step 1 and press alt+p to activate the project menu. 3. Choose properties. 4. Choose resource in the tree view. 5. Press tab until you find the second radio button. By the way, it needs a label. 6. Click other and press tab. You'll land in a combo box with three options: windows, linux and mac. 7. Choose windows and press OK. 8. Create a new class and insert some blank lines. 9. Try to scroll in the file with the arrows. The blank lines are not announced.
I just followed those steps in OpenSolaris. It's announcing them for me.... I'll have to try in Ubuntu I guess.
Created attachment 161745 [details] a small file to demonstrate the problem File created according to steps described in comment #1. At least for me the problem also can be reproduced using gedit. Open the file using gedit, scroll in the file and note that the blank lines are not announced. It seems that it is not a problem from eclipse.
retitling RFE, to reflect Jose's findings. Thanks Jose
Created attachment 161957 [details] [review] possible fix for bgo#619332. This seems to solve the issue for me. Also gets rid of the strange \r char that was shown on the braille display. At first I thought we should not remove something that is there, but when asking a sighted person, they cant see the \r character either (gedit). trying to put some text between the \r and \n character didnt work either, so this seems a safe patch. Jose, does this work well for you in Eclipse?
Review of attachment 161957 [details] [review]: Assuming it works for José, this patch looks good to me. In which case, once you get confirmation that Eclipse is fine, please commit it to master. And thanks for doing this!
(In reply to comment #5) > > Jose, does this work well for you in Eclipse? Works like a charm! Thanks.
Thanks Joanie, Jose, Commited to master.