GNOME Bugzilla – Bug 619318
[vp8] Decoder QoS (avoid memcpy)
Last modified: 2010-05-22 09:03:28 UTC
Created attachment 161678 [details] [review] patch The chosen solution may not be what ds had in mind, code review will tell.
commit 0285cff3006efea8be58ae703a1f1dff990badb6 Author: Philip Jägenstedt <philipj@opera.com> Date: Fri May 21 20:53:36 2010 +0200 vp8dec: drop late frames after decoding them This saves a memcpy, which is always something.
This changed the API of the private decoder base class, which we want to copy over into the public dir after the release, so some discussion on that might have been nice beforehand... (or did I miss that? The last I saw was ds saying 'no more features before the release' and that he was going to hack on that after the release.)
My plan was to add this now before the release because no QOS is apparently causing some problems. After release we can discuss a good API for this and change things.
I didn't think this would be taken in before the release, just wanted to submit it up front for discussion.
I have a small patch pending to fix an issue with the QoS handling in the base class... will attach it in a few minutes.
Created attachment 161699 [details] [review] basevideodecoder: Reset QoS values when necessary
Created attachment 161700 [details] [review] basevideodecoder: Take the frame duration into account when calculating the earliest time This formula is used in many other elements too.
commit 179555c45b8c58dded73acf7f600b14615fa167f Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat May 22 07:44:27 2010 +0200 basevideodecoder: Take the frame duration into account when calculating the earliest time This formula is used in many other elements too. Fixes bug #619318. commit 71ebf1add6f0456abb58f7656af942cbed3deb99 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat May 22 07:35:01 2010 +0200 basevideodecoder: Reset QoS values when necessary