GNOME Bugzilla – Bug 619315
Move EDS conduits from evolution to gnome-pilot
Last modified: 2010-08-09 08:14:46 UTC
For Evolution 3.0, the Evolution team would like to move the Evolution-Data-Server conduits for gnome-pilot directly into gnome-pilot. Since Evolution does not integrate with any other synchronization solutions (nor should it), it no longer makes sense for gnome-pilot to be the lone exception. This will also let us remove Evolution's dependency on gnome-pilot libraries, which most Evolution users don't need.
Created attachment 161675 [details] [review] Proposed patch This patch adds the Evolution-Data-Server conduits from Evolution to /conduits/evolution-data-server, along with a corresponding configure option: --enable-eds-conduits. The configure option defaults to "yes", but you can easily change that to "no" if you prefer. This is pretty much a copy and paste job from Evolution -- all I did was rewrite the build scripts. The patch bundles everything needed from Evolution, so the only new dependencies here are the Evolution-Data-Server libraries: libecal-1.2 libebook-1.2 libedataserverui-1.2
I should also mention the patch builds cleanly and passes distcheck, but is otherwise untested since I lack the necessary PDA hardware.
Since gnome-pilot depends on gtk+-2.0 and GNOME 2.31.4 will ship with gtk+-3.0 on June 28, I'm going to have to dump gnome-pilot support from Evolution whether this gets picked up or not. We can't link to any libraries that link to gtk+-2.0.
Thanks for the patch. I see the conduits are now removed on git master, so I presume this means they're in evo 2.30 and removed in 2.31.
Correct. I've actually been meaning to submit a new patch to account for the fact that Evolution 2.31 is now compliant with the XDG base directory specification, meaning we've done away with ~/.evolution. The patch in comment #1 hard-codes the user data directory in several places, so that needs fixed for 2.31.6 and beyond. I'll try to get that to you in the next day or two.
Created attachment 166902 [details] [review] Update to previous patch, to fix a few issues I've committed Matthew's patch to the dbus branch of gnome-pilot, which will become the master pretty soon now, I hope. This second patch just fixes a couple of minor issues. With these changes, the evo conduits built within gnome-pilot seem to work as expected.
Created attachment 166929 [details] [review] Update base directories for >= 2.31.6 This applies to your dbus branch. It uses the new base directories as of E-D-S 2.31.6, but retains compatibility back to the E-D-S version where the EDS_CHECK_VERSION macro was introduced (2.22 or 2.24, I think). Migration is already handled by e-addressbook-factory and e-calendar-factory, since they move the legacy local/system directories to their new home on startup. The conduit files will move with them.
Thanks. Committed to dbus branch.
Review of attachment 161675 [details] [review]: Thanks, committed.
Review of attachment 166929 [details] [review]: Committed
This is now committed to head.