After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619314 - final methods for samplers upsize (Locally Bounded Bicubic) and upsharp (Nohalo finished with LBB)
final methods for samplers upsize (Locally Bounded Bicubic) and upsharp (Noha...
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: operations
git master
Other All
: Normal enhancement
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2010-05-21 18:19 UTC by Nicolas Robidoux
Modified: 2012-01-20 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch which replaces the current gegl-sampler-upsize.c and ...upsharp.c by much improved methods (138.52 KB, patch)
2010-05-21 18:19 UTC, Nicolas Robidoux
none Details | Review
Quick visual test file for upsize sampler (uses the car-stack.png image in tests/compositions/data) (848 bytes, application/xml)
2010-05-21 18:21 UTC, Nicolas Robidoux
  Details
Quick visual test file for upsharp sampler (850 bytes, application/xml)
2010-05-21 18:22 UTC, Nicolas Robidoux
  Details
Quick visual test file for linear sampler (848 bytes, application/xml)
2010-05-21 18:23 UTC, Nicolas Robidoux
  Details
patch which replaces the current gegl-sampler-upsize.c and ...upsharp.c by much improved methods (138.34 KB, patch)
2010-05-21 18:50 UTC, Nicolas Robidoux
none Details | Review
super high quality (and most likely final) versions of the samplers upsize, upsharp and upsmooth (206.35 KB, patch)
2010-06-03 01:48 UTC, Nicolas Robidoux
none Details | Review
update of the up* samplers (215.06 KB, patch)
2010-06-05 20:40 UTC, Nicolas Robidoux
none Details | Review

Description Nicolas Robidoux 2010-05-21 18:19:22 UTC
Created attachment 161670 [details] [review]
patch which replaces the current gegl-sampler-upsize.c and ...upsharp.c by much improved methods

Final (!) one-for-one replacements for the samplers gegl-sampler-upsize.c and gegl-sampler-upsharp.c. (gegl-sampler-upsmooth.c still needs work.)

The results obtained with these two new methods are much more robustly high quality than for the methods they replace.

You may test quickly by putting the two xml files (not included in the patch) in gegl/tests/compositions and running them with, say, 

gegl upsizetest.xml -o upsizecar.png
gegl upsharptest.xml -o upsharpcar.png
gegl lineartest.xml -o linearcar.png

which enlarge the car-stack.png image 8x and rotates it by 7 degrees.

On my laptop, the runtime of the above upsize and upsharp xml's are about twice those of the linear xml.
Comment 1 Nicolas Robidoux 2010-05-21 18:21:15 UTC
Created attachment 161671 [details]
Quick visual test file for upsize sampler (uses the car-stack.png image in tests/compositions/data)
Comment 2 Nicolas Robidoux 2010-05-21 18:22:26 UTC
Created attachment 161672 [details]
Quick visual test file for upsharp sampler
Comment 3 Nicolas Robidoux 2010-05-21 18:23:26 UTC
Created attachment 161673 [details]
Quick visual test file for linear sampler
Comment 4 Nicolas Robidoux 2010-05-21 18:50:06 UTC
Created attachment 161674 [details] [review]
patch which replaces the current gegl-sampler-upsize.c and ...upsharp.c by much improved methods
Comment 5 Nicolas Robidoux 2010-06-03 01:48:05 UTC
Created attachment 162599 [details] [review]
super high quality (and most likely final) versions of the samplers upsize, upsharp and upsmooth

This adds the final version of upsmooth (which now uses a Jacobian-adaptive combination of vertex-split with quadratic B-splines finish (VSQBS) and bilinear) to the final versions of upsize (Locally Bounded Bicubic)and upsharp (Nohalo with LBB finish).
Comment 6 Nicolas Robidoux 2010-06-05 20:40:35 UTC
Created attachment 162822 [details] [review]
update of the up* samplers

The next generation will be focused on jaggy reduction.

upsmooth will become upsize
upsize will become upsharp
and upsharp will become upsmooth after the addition of a custom smoother.
Comment 7 Jon Nordby 2011-09-03 17:21:11 UTC
This work has been merged now, correct?
http://git.gnome.org/browse/gegl/commit/?id=b24670426d8ee31202295afa230a9fb0f3aeb5aa
Comment 8 Tobias Mueller 2012-01-20 17:08:53 UTC
Assuming comment #9 to be correct and closing as FIXED. If this is not the case, please reopen.