After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619247 - TerraParser does not catch all HTML entities
TerraParser does not catch all HTML entities
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.12.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 621344 621700 623762 623793 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-05-20 23:17 UTC by David Bate
Modified: 2010-07-07 23:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for bug (3.24 KB, patch)
2010-05-28 00:20 UTC, David Bate 		none Details | Review

Description David Bate 2010-05-20 23:17:00 UTC 
The TerraParser does not change the string "'" (an apostrophe) when fetching lyrics.  I have not encountered this bug for any other characters, however they are not very common in lyrics!

To reproduce this:
1) Enable only the TerraBrazil source in the lyric plugin and play a song with an apostrophe somewhere.

2)Observe that the string "'" appears where one expects an apostrophe.

Note that this does not happen for, say, the AstraWeb parser (this is the only other source I could find to return lyrics).
Comment 1 David Bate 2010-05-20 23:19:16 UTC 
Sorry, this was using Rhythmbox 0.12.8 on F13beta.
Comment 2 David Bate 2010-05-28 00:20:15 UTC 
Created attachment 162159 [details] [review]
Fix for bug
Comment 3 David Bate 2010-05-28 00:24:48 UTC 
I have found the source of this bug.  The file TerraParser.py requires a small correction to the compile code on line 39.  The line should instead be

pattern = re.compile("&(#?\w+?);")

I have also attached a modified version of the file that works for me.
Comment 4 Jonathan Matthew 2010-05-29 05:51:44 UTC 
Hi David,

Thanks for looking into this.  I've committed your suggested change.  When you've identified a specific change that fixes a problem, it's best to provide the change as a diff between the current version of the file and your fixed version.  So, you'd keep an unmodified copy of TerraParser.py (named TerraParser.py.old or something), make your changes, then run 'diff -u TerraParser.py.old TerraParser.py' and attach the output here.
Comment 5 Jonathan Matthew 2010-06-12 05:30:44 UTC 
*** Bug 621344 has been marked as a duplicate of this bug. ***
Comment 6 Jonathan Matthew 2010-06-15 21:26:41 UTC 
*** Bug 621700 has been marked as a duplicate of this bug. ***
Comment 7 Jonathan Matthew 2010-07-07 19:37:32 UTC 
*** Bug 623762 has been marked as a duplicate of this bug. ***
Comment 8 Jonathan Matthew 2010-07-07 23:07:50 UTC 
*** Bug 623793 has been marked as a duplicate of this bug. ***