GNOME Bugzilla – Bug 619236
application icons should be left aligned in overview dash
Last modified: 2010-06-08 21:52:03 UTC
Created attachment 161595 [details] screenshot It seems that when there aren't enough items to fill the well the items are centered. I think it would be better if the items were left/top aligned in a grid. Some relationship to bug 604057.
Created attachment 162837 [details] [review] [dash] Left align well items When the app well does not contain enough items to fill a single row, items are centered - the same applies to sections in the all-app menu.
Created attachment 162838 [details] [review] [dash] Right align well icons for RTL locales When changing the alignment of well icons from centered to left, we should swap it for RTL locales. The patch has the side effect of adding all items from right to left, but I imagine that this is desirable anyway ...
Seems like we have the same problem in the all apps view as well.
(In reply to comment #3) > Seems like we have the same problem in the all apps view as well. Yes. The attached patch works there as well.
Oh yeah, indeed it does. Looks great. Thanks!
Comment on attachment 162838 [details] [review] [dash] Right align well icons for RTL locales >+ let _x = box.x1 + box.x2 - (x + width); box.x2 is a coordinate, not a width, so you don't want to add it to box.x1. You just want "box.x2 - (x + width)". This code looks like it works, but it seems to be that it would be clearer if you had x start on the right and move left for the RTL case. (Maybe it wouldn't be, but looking at this code, it seems like it would.)
Comment on attachment 162837 [details] [review] [dash] Left align well items Attachment 162837 [details] pushed as cba4995 - [dash] Left align well items
Created attachment 163115 [details] [review] [dash] Right align well icons for RTL locales (In reply to comment #6) > This code looks like it works, but it seems to be that it would be clearer if > you had x start on the right and move left for the RTL case. (Maybe it wouldn't > be, but looking at this code, it seems like it would.) Possible, but I'm not convinced it's that much clearer - instead of a single conditional, we'd have four: let x; if (direction == RTL) x = ... else x = ... for (c in children) { ... // do stuff ... if (direction == RTL) c.x1 = ... else c.x1 = ... c.x2 = c.x1 + width; ... // do stuff ... if (column == 0) { if (direction == RTL) x = ... else x = ... } else { if (direction == RTL) x -= ... else x += ... } } Personally I think it's easier to follow the logic using the same calculations in both cases and do the necessary transformation in a single place as in the current patch; it's not a very strong feeling though, so if you want I can update it.
Comment on attachment 163115 [details] [review] [dash] Right align well icons for RTL locales ok, this is fine
Attachment 163115 [details] pushed as 87e5457 - [dash] Right align well icons for RTL locales