After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619198 - [matroskademux] GstEbmlRead cleanup
[matroskademux] GstEbmlRead cleanup
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 611117
 
 
Reported: 2010-05-20 14:24 UTC by Mark Nauwelaerts
Modified: 2010-06-01 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use GstEbmlRead as helper object (125.03 KB, patch)
2010-05-20 14:24 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2010-05-20 14:24:52 UTC 
Created attachment 161548 [details] [review]
use GstEbmlRead as helper object

That is, use GstEbmlRead as a bytereader based help object/structure, rather than as a base class.  Also use more common push and pull code paths.

While more EBML elements parsing code might still be compacted further, this at least does away with the HACKish parts and results in code and structure similar to other demuxers.  Incidentally, the refactoring also handles undefined cluster sizes and as such takes care of bug #611117.
Comment 1 Sebastian Dröge (slomo) 2010-06-01 10:15:57 UTC 
Looks good, please push this as soon as possible to get enough testing before next release :)
Comment 2 Mark Nauwelaerts 2010-06-01 14:09:03 UTC 
commit 085e333283086b3ed7d5836be85c60d5eee6db68
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Tue May 18 14:44:15 2010 +0200

    matroskademux: use bytereader based GstEbmlRead as a helper
    
    ... rather than basing on it by inheritance.
    Also use more common code for push and pull mode.
    
    Fixes #619198.
    Fixes #611117.