After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619169 - [vp8enc] Limit DEFAULT_MAX_LATENCY to 25 to match libvpx
[vp8enc] Limit DEFAULT_MAX_LATENCY to 25 to match libvpx
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-20 07:47 UTC by Philip Jägenstedt
Modified: 2010-05-20 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.17 KB, patch)
2010-05-20 07:47 UTC, Philip Jägenstedt
committed Details | Review

Description Philip Jägenstedt 2010-05-20 07:47:28 UTC
Created attachment 161522 [details] [review]
patch

From libvpx/vp8/encoder/onyx_int.h:
    
While we don't need to be tied to what libvpx does internally, it doesn't make sense to pretend to support longer frame lags than are actually possible.
Comment 1 Sebastian Dröge (slomo) 2010-05-20 08:37:51 UTC
Thanks... higher values make it impossible to initialize the encoder anyway. If this limit changes at some point we can still update the maximum value of that property.


commit 2f4ea3b73449050996e19bf65cedd4005b27ab1f
Author: Philip Jägenstedt <philipj@opera.com>
Date:   Thu May 20 09:24:53 2010 +0200

    vp8enc: Limit max-latency to 25 to match libvpx
    
    From libvpx/vp8/encoder/onyx_int.h:
     #define MAX_LAG_BUFFERS (CONFIG_REALTIME_ONLY? 1 : 25)
    
    While we don't need to be tied to what libvpx does internally, it
    doesn't make sense to pretend to support longer frame lags than are
    actually possible.