After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619120 - [GsmClient] Export _stop method
[GsmClient] Export _stop method
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-19 19:24 UTC by Colin Walters
Modified: 2010-05-20 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[GsmClient] Export _stop method (1.00 KB, patch)
2010-05-19 19:24 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2010-05-19 19:24:36 UTC 
This allows the shell to request that a client quit.
Comment 1 Colin Walters 2010-05-19 19:24:38 UTC 
Created attachment 161487 [details] [review]
[GsmClient] Export _stop method
Comment 2 Lucas Rocha 2010-05-20 01:11:15 UTC 
Review of attachment 161487 [details] [review]:

Looks good otherwise. Wondering: why do you need this?

::: gnome-session/org.gnome.SessionManager.Client.xml
@@ +66,3 @@
+      <doc:doc>
+        <doc:description>
+          <doc:para>Inititate a reuquest that this application terminate via XSMP.</doc:para>

Typo in request. Maybe a better version is "Initiate a request to terminate this application via XSMP"?
Comment 3 Colin Walters 2010-05-20 14:35:36 UTC 
Attachment 161487 [details] pushed as 017b5ee - [GsmClient] Export _stop method
Comment 4 Colin Walters 2010-05-20 14:38:05 UTC 
(In reply to comment #2)
> Review of attachment 161487 [details] [review]:
> 
> Looks good otherwise. Wondering: why do you need this?

So the implementation of GNOME Shell's "Quit" menu item can take advantage of an XSMP connection if available.  And also so that we can cleanly terminate apps before upgrading them.

> ::: gnome-session/org.gnome.SessionManager.Client.xml
> @@ +66,3 @@
> +      <doc:doc>
> +        <doc:description>
> +          <doc:para>Inititate a reuquest that this application terminate via
> XSMP.</doc:para>
> 
> Typo in request. Maybe a better version is "Initiate a request to terminate
> this application via XSMP"?

Fixed, thanks!