After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619113 - [panel] fix nested-queue_relayout warning in menus
[panel] fix nested-queue_relayout warning in menus
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-19 18:04 UTC by Dan Winship
Modified: 2010-05-19 21:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[panel] fix nested-queue_relayout warning in menus (3.29 KB, patch)
2010-05-19 18:04 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2010-05-19 18:04:15 UTC
We don't need to reposition the menu every time its button is
allocated; we can just stick it in the right place when we pop it up
(which is guaranteed to not be during a layout cycle).

(This means that now we won't reposition the menu if the button
moves/resizes while the menu is already popped up, but it's not clear
that we'd want it to anyway, since that could easily result in the
user selecting the wrong item, etc.)

Also, we don't need to override the menu's width any more, so remove
that.
Comment 1 Dan Winship 2010-05-19 18:04:17 UTC
Created attachment 161478 [details] [review]
[panel] fix nested-queue_relayout warning in menus
Comment 2 Colin Walters 2010-05-19 18:20:16 UTC
Review of attachment 161478 [details] [review]:

Makes sense, thanks!
Comment 3 Dan Winship 2010-05-19 21:07:19 UTC
Attachment 161478 [details] pushed as c8f4add - [panel] fix nested-queue_relayout warning in menus