GNOME Bugzilla – Bug 619101
Duplicate caret-moved events in OOo Writer are causing Orca to double-speak lines of text
Last modified: 2010-06-18 14:22:19 UTC
Dear Developers, Now I not remember I reported already this bug or not, sorry if this is an already reported issue. :-):-) I found a disturb problem with Orca and Openoffice.org 3.2 use: When I open a document with Openoffice.org Writer, and read a document with up and down arrow keys, Orca lot of time spokening two time the actual line. for example: First, I press a down arrow key, Orca spokening following lines two time: Remember Remember I press down arrow key, Orca spokening following text with a blank line: Blank Blank Again press down arrow key, Orca spokening following line: This is a test text. This is a test text. I make a debug.out file, very hope show why happening this problem. I see this problem under Orca 2.30 version and git master version. In my Ubuntu Lucid system, following Openoffice.org package version is present: 1:3.2.0-7ubuntu4 Next comment I attaching a debug.out file. Attila
Created attachment 161463 [details] This is the promised debug.out file, possible this is show what the problem.
Thanks Attila. It looks like we're getting duplicate caret-moved events. Bah.
Created attachment 161513 [details] [review] Patch to improve -- and possibly fix? -- the situation Attila, this solves the problem for me. But when I compare the duplicates I was getting to what your debug.out indicates you're getting, you are definitely seeing more repeats than I am. Regardless.... This patch should make things better for you. And it may just flat out solve the problem. Please test with the following in mind: * If you have duplicates that this patch is failing to catch, it would be helpful not only to have the debug.out captured during that test, but also the exact document you were reading and/or the exact steps you took to reproduce the problem. * This should not have broken anything, but nonetheless please be on the lookout for breakage. Note that this change is isolated to the OOo script, so it cannot break things in, say, Gecko. If you suspect this patch did break something in OOo, please reverse the patch, rebuild Orca, restart Orca and verify that the patch is indeed to blame. Thanks much! I look forward to your results. p.s. This patch is master-compatible only. We'll cross the 2.30.2 bridge later.
Joanmarie, I tested shorter your patch. The change is very good, I read two entire document with down arrow key, and not see the line spokening duplication. Prewious time I use simple oowriter documentname command with gnome-terminal when I would like quicq open a document, and after Openoffice.org Writer is launched, I begin press down arrow keys and up arrow keys to show the line spokening repetation when I make the debug.out. Now, this reproducation test is not do this line duplication spokening problem after I applyed your patch, uninstall and reinstall Orca. I veryfied the patch working with a longer document (a big scanned book), I see same good results. Thank you very mutch this patch and possible later 2.30.2 implementation, Attila
Comment on attachment 161513 [details] [review] Patch to improve -- and possibly fix? -- the situation http://git.gnome.org/browse/orca/commit/?id=483a070f15641962b1326868df5d4f869d3f8174
Thanks Attila. The patch has been committed to master. I'm closing this bug as FIXED, but have marked it for consideration for the 2.30.2 release. That'll give you and others time to test it more before we decide.
Thank you joanie the quick fix and master commit. I do lot of document editing with next week in Openoffice, so this is good time the testing in next week. :-):-) If I found any another OO related bug when editing special documents in OO Writer, i will be report. For example I found an interesting issue prewious time if I editing HTML formatted documents, but I need debugging this problem before report: If I insert links with document, Orca not spokening the link containing line, but this is another problem and not this related bug. So, thank you very mutch the fix, Attila
The fix for this bug will be included in the 2.30.2 release. http://git.gnome.org/browse/orca/commit/?id=4cfad29d870b5693943e0147609be6d4edc058aa