After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619035 - Amiga Modules (XM/MOD/IT/S3M) do not play in stereo
Amiga Modules (XM/MOD/IT/S3M) do not play in stereo
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.18
Other Linux
: Normal minor
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-18 22:01 UTC by roundsoftstudio
Modified: 2012-10-06 11:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
finally files are played as stereo(instead of mono) AND 44100 Hz (637 bytes, patch)
2011-11-23 11:50 UTC, Krzysztof Krakowiak
none Details | Review
finally files are played as stereo(instead of mono) (1.29 KB, patch)
2011-11-23 14:52 UTC, Krzysztof Krakowiak
committed Details | Review

Description roundsoftstudio 2010-05-18 22:01:27 UTC
Every Amiga module is played with an underrated volume, and in mono. That plugin is just sabotage.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2010-07-03 20:43:07 UTC
We're using libmodplug. Could you please discuss the issue there?
Comment 2 Felipe Besoaín Pino 2010-10-18 12:24:46 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Comment 3 Krzysztof Krakowiak 2011-11-23 11:50:32 UTC
Created attachment 201991 [details] [review]
finally files are played as stereo(instead of mono) AND 44100 Hz

I am not programmer, not sure if its correct, but worksforme(for stereo files).
Even if its not correct, original conditions seems illogical and not making any sense(I dont know gstreamer, but why 'return' when SUCCESS (maybe origin attemp was to return ERRORCODE, but becasuse VOID functions cannot do that, he decided to...)
Comment 4 Krzysztof Krakowiak 2011-11-23 14:52:45 UTC
Created attachment 201999 [details] [review]
finally files are played as stereo(instead of mono)
Comment 5 Vincent Penquerc'h 2011-11-23 15:36:36 UTC
commit 4286414e002016e6f3837696b0dec708d59787dc
Author: Krzysztof Krakowiak <krzysztof.krakowiak@gmail.com>
Date:   Wed Nov 23 13:47:11 2011 +0100

    modplug: fix modules playing as mono instead of stereo
    
    replaced broken if-return logic for fixating rate and number
    of channels that caused that modules were always (after
    successful fixation of rate) played as mono (instead of
    stereo) by correct one with appropiate warnings.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=619035
Comment 6 Vincent Penquerc'h 2011-12-12 16:22:36 UTC
You (IIRC) mentioned on IRC that you were seeing something else that needed fixing, can you shed some light on this, or can this be closed as fixed ?
Comment 7 Vincent Penquerc'h 2011-12-12 16:23:22 UTC
And by "you", I mean Krzysztof :)
Comment 8 Akhil Laddha 2012-01-30 10:14:50 UTC
Krzysztof, ping, can you please provide requested information as per comment#6 ?
Comment 9 Krzysztof Krakowiak 2012-02-05 19:31:48 UTC
(In reply to comment #6)
> You (IIRC) mentioned on IRC that you were seeing something else that needed
> fixing, can you shed some light on this, or can this be closed as fixed ?

Hi,
Sorry for not replying so long.

This bug is fixed when converting to MP3, but there is other general bug in gstreamer that causes files to be mono when converting to Ogg Vorbis from some audio formats
-- cut here --
<v^> It might be that Vorbis chooses 1 channel in preference. See https://bugzilla.gnome.org/show_bug.cgi?id=590361
...
<evil_core> v^: "Elements should not use 
<evil_core> gst_structure_fixate_field_nearest_int()"
<evil_core> elements are decoder, like what I was playing and those fixation's functions should be removed totally?
<v^> evil_core: it is needed if vorbisenc and decodebin have no common format. As for _fixate, I did not know it should not be used by elements. Maybe look at the plugin history to see if it replaced some other code.
<evil_core> v^: vorbisenc doesnt have "channels" parameter :/
<v^> I does. It's wrong though, IIRC it's 255 max, and it says 256.
<v^> Oh, it's in caps, not as a property, in case you meant this.
-- cut here --

You can test it using mine shell script:
http://carme.pld-linux.org/~evil/varia/pgmc

Or run directly:
/usr/bin/gst-launch-0.10 filesrc location=01-Intro.it ! decodebin ! audioconvert ! audioresample ! vorbisenc name=enc quality=.3 ! oggmux ! filesink location=./01-Intro.ogg
Comment 10 Stefan Sauer (gstreamer, gtkdoc dev) 2012-03-23 15:11:44 UTC
The vorbisenc channels part is fixed.
channels: [ 1, 255 ]
Comment 11 Stefan Sauer (gstreamer, gtkdoc dev) 2012-03-23 19:22:25 UTC
Using decodebin2 makes it work for me:

gst-launch-0.10 filesrc location=spacedeb.mod ! decodebin2 ! audioconvert ! audioresample ! vorbisenc name=enc quality=.3 ! oggmux ! filesink location=spacedeb.ogg