After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619012 - Empathy's log viewer shows wrong date for some messages
Empathy's log viewer shows wrong date for some messages
Status: RESOLVED NOTGNOME
Product: empathy
Classification: Core
Component: Archives
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-18 18:13 UTC by TH
Modified: 2010-09-21 08:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (8.97 KB, patch)
2010-09-20 18:56 UTC, Vitaly Minko 		reviewed Details | Review

Description TH 2010-05-18 18:13:45 UTC 
It seems like the logfile is saved in UTC-time, while the logviewer adjusts the time to the local timezone. However, the date in the "Previous Conversations" dialogue is not adjusted when in another timezone, i.e. UTC+0100.


Steps to reproduce:
1) Create a log file with the name "20100517.log" and the following content:

<?xml version='1.0' encoding='utf-8'?>
<?xml-stylesheet type="text/xsl" href="empathy-log.xsl"?>
<log>
<message time='20100517T23:45:00' cm_id='0' id='mail@example.com' name='EmpTest' token='' isuser='true' type='normal'>This is just for testing!</message>
</log>

2) Find the message in the "Previous Conversations" dialogue and notice the date, both in the list of search results and the date picker.


Expected result:
The date should be 18.05.2010 when in UTC+0100.


Actual result:
The date shows 17.05.2010, although this is wrong.
Comment 1 Vitaly Minko 2010-09-20 18:56:51 UTC 
Created attachment 170692 [details] [review]
proposed fix

The proposed fix implements the following approach:
1. Request messages for additional date (+/- 1 day depending on time zone) if time zone offset is not zero.
2. Pass to the UI only messages from the selected local date (remove extra messages).
Comment 2 Guillaume Desmottes 2010-09-21 08:00:07 UTC 
Review of attachment 170692 [details] [review]:

Thanks for your patch but that's the wrong approach. This should be fixed in telepathy-logger directly.
Comment 3 Guillaume Desmottes 2010-09-21 08:02:00 UTC 
I forwarded this bug to telepathy-logger: https://bugs.freedesktop.org/show_bug.cgi?id=30298