After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619008 - make PanelMenu keyboard-navigable
make PanelMenu keyboard-navigable
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-18 17:32 UTC by Dan Winship
Modified: 2010-05-19 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[panel] split out a PanelBaseMenuItem class (4.60 KB, patch)
2010-05-18 17:32 UTC, Dan Winship 		committed Details | Review
[panel] separate "active" state from hover state in PanelBaseMenuItem (2.03 KB, patch)
2010-05-18 17:33 UTC, Dan Winship 		committed Details | Review
[panel] add keyboard navigation of menus (5.99 KB, patch)
2010-05-18 17:33 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2010-05-18 17:32:55 UTC 
there's no way to get to the panel menus using just the keyboard yet,
but if you click open a menu, you can then navigate among the menu items
and between the two menus.

The behavior should be the same as how gtk menus/items behave.
Comment 1 Dan Winship 2010-05-18 17:32:57 UTC 
Created attachment 161370 [details] [review]
[panel] split out a PanelBaseMenuItem class

Make the existing PanelMenuItem, PanelSeparatorMenuItem,
PanelImageMenuItem inherit from it.
Comment 2 Dan Winship 2010-05-18 17:33:01 UTC 
Created attachment 161371 [details] [review]
[panel] separate "active" state from hover state in PanelBaseMenuItem

When doing keyboard navigation, the active menu item may not be the
one under the mouse.
Comment 3 Dan Winship 2010-05-18 17:33:07 UTC 
Created attachment 161372 [details] [review]
[panel] add keyboard navigation of menus
Comment 4 Colin Walters 2010-05-19 16:36:18 UTC 
Review of attachment 161370 [details] [review]:

Looks fine.
Comment 5 Colin Walters 2010-05-19 16:44:43 UTC 
Review of attachment 161371 [details] [review]:

Looks fine.
Comment 6 Colin Walters 2010-05-19 16:50:32 UTC 
Review of attachment 161372 [details] [review]:

Looks good.
Comment 7 Dan Winship 2010-05-19 17:17:47 UTC 
Attachment 161370 [details] pushed as 320adb3 - [panel] split out a PanelBaseMenuItem class
Attachment 161371 [details] pushed as 2179f58 - [panel] separate "active" state from hover state in PanelBaseMenuItem
Attachment 161372 [details] pushed as 9b3e165 - [panel] add keyboard navigation of menus