After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619007 - [PATCH] correctly handle floating objects
[PATCH] correctly handle floating objects
Status: RESOLVED FIXED
Product: pygi
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: 0.6
Assigned To: pygi-maint
pygi-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-18 17:32 UTC by johnp
Modified: 2010-05-22 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] correctly handle floating objects in gtk (1.02 KB, patch)
2010-05-18 17:32 UTC, johnp
committed Details | Review

Description johnp 2010-05-18 17:32:00 UTC
This patch registers a sink with pygobject which checks to see if the object being wrapped is a floating object and sink_refs it if it is.

This is a temporary fix to the real fix in pygobject:

https://bugzilla.gnome.org/show_bug.cgi?id=583909

Once that gets in this patch does not have to be reverted as the pygobject_register_sinkfunc becomes a noop.
Comment 1 johnp 2010-05-18 17:32:45 UTC
Created attachment 161369 [details] [review]
[PATCH] correctly handle floating objects in gtk


* this is a stopgap so we work with older pygobject libraries
* there is a patch at https://bugzilla.gnome.org/show_bug.cgi?id=583909
  which adds the correct fix to pygobject
* once pygobject accepts the above patch this patch does not need to
  be reverted because pygobject_register_sinkfunc becomes a noop
---
 gi/gimodule.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)