GNOME Bugzilla – Bug 618981
Orca sometimes speaks the entire line of a Thunderbird message when Home or End are pressed
Last modified: 2010-09-20 10:52:51 UTC
Dear Developers, I tested following problem with Orca 2.30.1 and latest Orca git master version: When I compose a new message or reply a new message, if the message body containing only one line and I press Home and End key after I finish the line typing, Orca is say entire line. This problem is not happening when the message body is containing more than one line. The reproducation is very easy: 1. Launch Thunderbird. 2. Press for example the Ctrl+n or Ctrl+r key combination. Jump the message body, and write for example following text: Hello ewerybody! If you finish the typing, press Home and after this you press End key, you hear entire first line text. I using Ubuntu 10.04, Thunderbird 3.0.4 and Orca git master version with uptodated, but verifying this problem my wife Ubuntu 10.04 system. She using following important components: System: Ubuntu10.04 Thunderbird version: 3.0.4 Orca version: 2.30.1 Next comment I attaching a debug.out file, I hope this debug.out shows why happening this problem. Attila
Created attachment 161352 [details] This is the promised debug.out file I doed my prewious wroted reproducation steps when Orca debug feature is used, I hope this debug.out solwing why happening this problem under Orca 2.30 and Orca git master version. Attila
I'll take a look. Thanks!
Created attachment 161506 [details] [review] proposed fix This solves it for me. I'm using this version of Thunderbird: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9.3a5pre) Gecko/20100514 Shredder/3.2a1pre Please test. Thanks!
Joanmarie, I tested the patch with Orca git master and Thunderbird 3.0.4 version, I see equals good result with you. My first comment wroted reproducation test is not producing the reported problem. Thank you the fix, Attila
Comment on attachment 161506 [details] [review] proposed fix http://git.gnome.org/browse/orca/commit/?id=5b76a6f89673955260685b9a599634700ce316ce
Thanks Attila! I've committed this patch to master. We'll consider it for GNOME 2.30.2.
In terms of considering this fix for inclusion in 2.30.2: 1. The problem only seems to occur if: A. You're composing (rather than reading) a message in Thunderbird B. The message contains one and only one line of text C. You press Home or End 2. The result is the speaking of a line rather than a character 3. The fix involves changes to two frequently-used methods: A. _generateName() B. sayCharacter() So this is a low-impact, possibly high-risk change. The only thing we put back into the stable branch are high-impact, low-risk changes. Therefore, I'm afraid I'm rejecting this fix for inclusion in 2.30.2. Sorry.