GNOME Bugzilla – Bug 618979
[patch] balsa-2.4.7 fails to build with --as-needed
Last modified: 2011-02-27 15:44:32 UTC
Created attachment 161351 [details] [review] adding missing dependency on gthread-2.0 Steps to reproduce: 1. export LDFLAGS="-Wl,--as-needed" 2. configure --enable-threads --with-unique --without-canberra --without-gnome --without-gtksourceview --with-gtkspell --without-gss --without-ldap --without-libnotify --without-nm --without-rubrica --without-sqlite --with-ssl --without-compface 3. make Error: CCLD balsa main.o: In function `main': main.c:(.text+0xac3): undefined reference to `g_thread_init' collect2: ld returned 1 exit status Downstream bug: http://bugs.gentoo.org/show_bug.cgi?id=320349 Best regards, Kacper Kowalik
Hi Kacper! Thanks for the report. I've no objection to the patch, as it doesn't seem to break anything. But I couldn't reproduce the error, with the precise steps you gave. Is it dependent on specific versions of gcc or glib? Peter
(In reply to comment #1) > Hi Kacper! > > Thanks for the report. I've no objection to the patch, as it doesn't seem to > break anything. But I couldn't reproduce the error, with the precise steps you > gave. Is it dependent on specific versions of gcc or glib? > > Peter No it's not dependant on version of gcc nor glib. Problems in reproducibility may arise from the fact that on non "as-needed" system gthreads might be already brought in by some package from balsa's dependency set. Best regards, Kacper Kowalik
OK--your patch has been pushed to git master, along with another change adding libz to the linker command. Thanks again for the report and the patch! Peter
as gentoo maintainer, confirming this now works fine in 2.4.8 and 2.4.9. Thanks for your work.