After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618969 - Incomplete localisation of g-c-c module
Incomplete localisation of g-c-c module
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-18 10:13 UTC by Rob Bradford
Modified: 2010-05-18 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix (3.81 KB, patch)
2010-05-18 10:36 UTC, Rob Bradford 		accepted-commit_now Details | Review

Description Rob Bradford 2010-05-18 10:13:10 UTC 
Good morning!

The source files that we include in g-c-c module must used the library method for i18n. Failure to do this results in some of the strings being shown unlocalised.
Comment 1 Rob Bradford 2010-05-18 10:33:23 UTC 
Patch ready. Just doing final testing on it.
Comment 2 Rob Bradford 2010-05-18 10:36:13 UTC 
Created attachment 161329 [details] [review]
Patch to fix
Comment 3 Guillaume Desmottes 2010-05-18 10:38:05 UTC 
Review of attachment 161329 [details] [review]:

Looks good. Please merge to 2.30 and master once you've checked it fixes all the issues.
Comment 4 Rob Bradford 2010-05-18 10:54:41 UTC 
All committed. Thanks Guillaume!