GNOME Bugzilla – Bug 618940
rtptheorapay/depay wrongly claims to do delivery-method=inline
Last modified: 2010-06-03 22:48:37 UTC
The payloader's static caps do not include a "configuration" parameter, so having the delivery method as inline is a lie. The depayloader can also support in-band, so it was also a lie there.
Created attachment 161290 [details] [review] patch to fix the static caps in rtptheorapay/depay
It seems the above patch also includes a change to common/ (which is probably not intended). Also, the payloader code will still effectively produce src caps that do have delivery-method=inline, so the template src caps are not so much a lie in that case (and present RFC still seems to have delivery-method required ...)?
Arg, I hate common/ The payloader will also send the caps in-band, so delivery-method should be "inline & inband".. Anyway, looking at the delivery method is a bit a waste of time if you ask me.
What's the conclusion on this?
Created attachment 161949 [details] [review] improved caps Improved patch that also avoids setting the property on the srcpad and parsing the property.
commit 49463a37cbaa952e1401291f0a2623de6cab3880 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Tue May 25 17:05:12 2010 +0200 rtptheora: remove delivery-method from caps We can accept all delivery methods so don't advertise anything on the caps or parse anything, we will handle whatever we receive. Fixes #618940
This breaks compatibility with people running old versions of farsight2/gstreamer for Theora as a codec for VOIP.. While we might not care about how receive the configurations stuff, we should still announce it for compatibility reasons..
Created attachment 162387 [details] [review] Let the payloader announce the delivery-method it uses for backwards compatibiliyt
Comment on attachment 162387 [details] [review] Let the payloader announce the delivery-method it uses for backwards compatibiliyt looks good to me
Comment on attachment 162387 [details] [review] Let the payloader announce the delivery-method it uses for backwards compatibiliyt commit 952fd666b3278c2780777e14f8523a7c5fafee2f Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: Mon May 31 16:26:19 2010 +0100 Keep announcing the delivery-method in the capabilities Even though we don't use delivery-method in our payloader, older versions of the theora payloader in gstreamer required it. As such we need to keep this around in the caps for backwards-compatibility. This reverts part of 49463a37cbaa952e1401291f0a2623de6cab3880 Fixes #618940