GNOME Bugzilla – Bug 618863
Table structural navigation not working with th element in Firefox 3.6
Last modified: 2010-06-18 15:28:25 UTC
Created attachment 161214 [details] Testing file referred to in steps to reproduce. Uses the TH element to represent column headers. Hi, using e.g. Ubuntu 10.04 with Firefox 3.6, I am unable to use table structural navigation with orca in that browser. To reproduce: 0. Start orca 1. Open attached test-th.html in Firefox 2. Press "t" 3. Press alt+shift+(right or down) arrow Expected results: orca gets to the appropriate neighbour cell and speaks its contents (as if you do it with "test-td.html" which is second attachment to this report and uses td element instead of th element). Actual results: orca says: "Not in a table" I did a bit of research with accerciser and found these differences between test-td.html and test-th.html. First, the state of the table is "enabled, horizontal, sensitive" in the th case and "enabled, horizontal, opaque, sensitive, showing, visible" in the td case. Same with list items representing the table rows. Now the cells in the first row (column headers) have the "table cell" role in the td case and "column header" role in the th case. Also all cells (including headers) get the "selectable" attribute atop those of their parent table, and have table-cell-index attribute set appropriately and display attribute set to "table-cell". Best regards, Boris Dusek
Created attachment 161215 [details] Testing file that uses TD elements for column headers
Thanks for the report Boris! I'll take a look and see what I can do.
I just tried this using Firefox 3.6.5 built 14 May and Orca from git master and table navigation is working as expected for me. Orca doesn't say "Not in a table" and I am able to navigate into the headers using Orca's table navigation commands. What versions of everything are you using? If earlier versions, could you please download Firefox 3.6.5 and try. Based on your findings in Accerciser, I'm wondering if this was a bug in Firefox that has since been fixed.
Oops, never mind. Now I can repro it. Sorry for the spam. <back to looking>
(In reply to comment #0) > headers) get the "selectable" attribute atop those of their parent table sorry, I meant "selectable" state, not attribute. Anyway, thanks for replying so fast.
Created attachment 161219 [details] [review] proposed fix This solves the problem for me and works with both test cases in both Firefox 3.5.9 and Firefox 3.6.5. Because we also have structural navigation for tables in OOo Writer, I need to regression test this.
Thank you for the quick fix, Joanmarie. I confirm it works in my case. Just out of curiosity, do I understand it well that Firefox is exporting AT-SPI things correctly and it was purely a bug in Orca?
Thanks for the confirmation! As to whose bug it is: Firefox changed things necessitating a change in Orca. Thanks for catching it and filing the report!
Comment on attachment 161219 [details] [review] proposed fix Regression tested fine. http://git.gnome.org/browse/orca/commit/?id=d6222691a6546cbfb6b220f54e2ea131a90a40cd
(In reply to comment #7) > I confirm it works in my case. Sorry for not stating explicitely, "my case" means default install of Ubuntu Lucid 10.04 with orca from git and your patch applied. Unfortunately the patch does not apply on orca shipped with Ubuntu Lucid 10.04 (which is gnome-orca 2.30.0-0ubuntu3), so I could not test there. Thanks again, Boris
Thanks Boris. That's what I assumed since the patch isn't compatible with the gnome-2-30 branch. :-) The reason I added 2.30.2? to the whiteboard is to let this fix simmer for a while and get user testing. If it proves stable, I'll go back at commit it to the gnome-2-30 branch which will cause it to be delivered as an Ubuntu upgrade to the gnome-orca package late June.
This fix falls under the heading of 'high impact' and is pretty low risk. Plus, it's been tested (functionally and via automated regression tests) quite a bit. Therefore, I'm including it in the 2.30.2 release. http://git.gnome.org/browse/orca/commit/?id=523dce7be8459671b90a4e055d44f7bf63b2d385