GNOME Bugzilla – Bug 618823
plparse/Makefile.am: Improve the rules for totemplparser-marshal.{c,h}, re-adding support for automake 1.9
Last modified: 2010-05-18 15:15:23 UTC
Created attachment 161192 [details] [review] patch to require automake >= 1.10 $(builddir) is not available with automake 1.9: <-- snip --> ... ( /usr/bin/glib-genmarshal --prefix=totemplparser_marshal ./totemplparser-marshal.list --header --internal > /totemplparser-marshal.h ) /bin/sh: /totemplparser-marshal.h: Permission denied make: *** [totemplparser-marshal.h] Error 1 <-- snip --> Caused by commit 9f73be4d36d873136da4ee5016758bdf4f9ca8df (Don't distribute generated marshal files).
Why not fix the make rule instead, e.g. like this: totemplparser-marshal.c: totemplparser-marshal.h $(AM_V_GEN) $(GLIB_GENMARSHAL) --prefix=totemplparser_marshal --header --body --internal $< > $@
(In reply to comment #1) > Why not fix the make rule instead, e.g. like this: > > totemplparser-marshal.c: totemplparser-marshal.h > $(AM_V_GEN) $(GLIB_GENMARSHAL) --prefix=totemplparser_marshal --header > --body --internal $< > $@ $< is buggy this way (Should totemplparser-marshal.c depend on totemplparser-marshal.list instead of totemplparser-marshal.h? It would look logical.). Otherwise your suggestion looks better than the current rule.
Right, the dep line should be totemplparser-marshal.c: totemplparser-marshal.list
Created attachment 161353 [details] [review] plparse/Makefile.am: Improve the rules for totemplparser-marshal.{c,h} Based on a suggestion by Christian Persch. This also fixes building with automake 1.9.
Attachment 161353 [details] pushed as 234749a - plparse/Makefile.am: Improve the rules for totemplparser-marshal.{c,h}