After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618798 - FolderExport still uses gnome-vfs
FolderExport still uses gnome-vfs
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Export
0.6.2
Other Linux
: Normal blocker
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: 590832 618966
 
 
Reported: 2010-05-16 17:11 UTC by Ruben Vermeersch
Modified: 2010-05-18 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Getting rid of gvfs in FolderExport (8.31 KB, patch)
2010-05-17 14:40 UTC, Paul Wellner Bou 		needs-work Details | Review
Getting rid of gvfs in FolderExport (8.05 KB, patch)
2010-05-17 15:13 UTC, Paul Wellner Bou 		none Details | Review
Fixes bug #618798, getting rid of gnomeVfs (8.05 KB, patch)
2010-05-18 10:36 UTC, Paul Wellner Bou 		committed Details | Review
add file extensions to implement recursive copy (876 bytes, patch)
2010-05-18 10:36 UTC, Paul Wellner Bou 		committed Details | Review
Implement recursive copy (debug mode) (5.21 KB, patch)
2010-05-18 10:36 UTC, Paul Wellner Bou 		committed Details | Review
Fixing FolderExport using recursive FileExtensions.RecursiveCopy (5.56 KB, patch)
2010-05-18 10:36 UTC, Paul Wellner Bou 		committed Details | Review

Description Ruben Vermeersch 2010-05-16 17:11:17 UTC 
Needs to be fixed!
Comment 1 Paul Wellner Bou 2010-05-17 14:40:17 UTC 
Created attachment 161227 [details] [review]
Getting rid of gvfs in FolderExport

Fixed in attached patch.

Original patch by Lorenzo Milesi, dialog fix by Christopher James Halse Rogers, see header comment in patch.

Not tested: Export to non native locations. Not sure if the Copy () method used works out of the box then.
Comment 2 Ruben Vermeersch 2010-05-17 14:53:18 UTC 
Review of attachment 161227 [details] [review]:

Looks good, haven't tested it yet but it should be okay. Fix the commit message though.
Comment 3 Paul Wellner Bou 2010-05-17 15:13:13 UTC 
Created attachment 161230 [details] [review]
Getting rid of gvfs in FolderExport

Separating from dialog issue, reformatting commit comment.

See http://gitorious.org/~paulwb/f-spot/paulwbs-clone/commits/bgo618798
Comment 4 Paul Wellner Bou 2010-05-18 10:36:08 UTC 
Created attachment 161327 [details] [review]
Fixes bug #618798, getting rid of gnomeVfs

Original patch by and all credits to Lorenzo Milesi <maxxer@yetopen.it>.
Comment 5 Paul Wellner Bou 2010-05-18 10:36:11 UTC 
Created attachment 161328 [details] [review]
add file extensions to implement recursive copy
Comment 6 Paul Wellner Bou 2010-05-18 10:36:14 UTC 
Created attachment 161330 [details] [review]
Implement recursive copy (debug mode)
Comment 7 Paul Wellner Bou 2010-05-18 10:36:17 UTC 
Created attachment 161331 [details] [review]
Fixing FolderExport using recursive FileExtensions.RecursiveCopy
Comment 8 Paul Wellner Bou 2010-05-18 10:51:18 UTC 
Includes patch of #618966.
Comment 9 Ruben Vermeersch 2010-05-18 18:38:52 UTC 
Merged your work with some changes. Some stuff needs improving though, I created bug 619014, could you take care of those? Should be relatively easy to fix.

Thanks already, good stuff!