After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618613 - Fix crash with --sync option
Fix crash with --sync option
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-14 12:01 UTC by Tomas Frydrych
Modified: 2010-05-25 18:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to avoid crash (928 bytes, patch)
2010-05-14 12:01 UTC, Tomas Frydrych 		none Details | Review
Fix crash with --sync option (889 bytes, patch)
2010-05-25 17:28 UTC, Owen Taylor 		committed Details | Review

Description Tomas Frydrych 2010-05-14 12:01:30 UTC 
Created attachment 161044 [details] [review]
Patch to avoid crash

meta_set_syncing() can only be called after meta_display_open() has been
called, as it requires the MetaDisplay object.
Comment 1 Owen Taylor 2010-05-25 17:28:44 UTC 
Created attachment 161962 [details] [review]
Fix crash with --sync option

The current code is clearly meant to be lazy - it saves the
value to a variable and synchronizes the immediately after
opening the display if the variable is set.

So it's better to fix that than to move the meta_set_syncing()
call, since moving the call means that the initial display
set up won't be synchronized.
Comment 2 Owen Taylor 2010-05-25 17:30:31 UTC 
Metacity bug is bug 557514
Comment 3 Owen Taylor 2010-05-25 18:15:25 UTC 
Thomas committed the patch to Metacity, so counting that as review.

Attachment 161962 [details] pushed as f45083c - Fix crash with --sync option