GNOME Bugzilla – Bug 618522
[asfmux][patch] Improve support for streaming
Last modified: 2010-06-08 17:53:33 UTC
The following patches improves the support for live streaming: * Add headers to streamheader * Add preroll property in the initial headers * Set the seekable flag in videos to FALSE if it's live
Created attachment 160960 [details] [review] 0001-asfmux-put-headers-in-streamheader-for-streaming.patch
Created attachment 160961 [details] [review] 0002-asfmux-write-preroll-info-in-the-header-at-initializ.patch
Created attachment 160962 [details] [review] 0003-asfmux-don-t-set-the-seekable-flag-if-we-are-streami.patch
Review of attachment 160960 [details] [review]: Looks good, except that it should only add it to the caps if 'is-live' is true, otherwise the headers are not correct until rewriting right before EOS.
Review of attachment 160962 [details] [review]: Commit after freeze.
Review of attachment 160960 [details] [review]: One more thing is that the way you provided the patch made it lose the commit message.
Review of attachment 160961 [details] [review]: Commit after freeze.
Created attachment 161031 [details] [review] 0001-asfmux-put-headers-in-streamheader-for-streaming.patch Update streamheaders patch to add them only when 'is-live'
Pushed. commit 40209aa30fa1b88af1bed05291bf6ac87a5d64e3 Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Thu May 13 12:15:27 2010 +0200 asfmux: don't set the 'seekable' flag if we are streaming Fixes #618522 commit 2a94798136cef02a55f8032a939565c9487a1e9e Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Thu Apr 29 10:46:49 2010 +0200 asfmux: write preroll info in the header at initialization This value doesn't need to be updated and is usefull in a streaming context Fixes #618522 commit 003949422786af7652925bdf7d6f0c252dcf61ec Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Mon Apr 26 13:33:48 2010 +0200 asfmux: put headers in streamheader for streaming Fixes #618522