After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618499 - building nss in default moduleset breaks jhbuild
building nss in default moduleset breaks jhbuild
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2010-05-13 02:56 UTC by William Jon McCann
Modified: 2010-12-10 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Cleanup nspr and nss patches (189.24 KB, patch)
2010-11-24 11:31 UTC, Craig Keogh
none Details | Review
Cleanup nspr and nss patches (189.46 KB, patch)
2010-12-02 09:45 UTC, Craig Keogh
committed Details | Review

Description William Jon McCann 2010-05-13 02:56:52 UTC
After building nss in the default moduleset jhbuild fails because of the following error:
curl: /opt/gnome2/lib/libfreebl3.so: version `NSSRAWHASH_3.12.3' not found (required by /lib/libcrypt.so.1)

It seems that it is picking up the wrong libraries.  Perhaps we should unset environment variables like LD_LIBRARY_PATH before running external commands.  Will test this.
Comment 1 Frederic Peters 2010-05-13 17:36:58 UTC
Thanks for your report.

commit e5bd9d9659f0100075ef977c3332e27efda6b652
Author: Frédéric Péters <fpeters@0d.be>
Date:   Thu May 13 19:35:31 2010 +0200

    Run wget & curl with host environment (GNOME bug 618499)
    
    This avoids getting curl linking against the jhbuild'ed nss, and failing on
    unknown symbols.
Comment 2 William Jon McCann 2010-05-13 23:09:27 UTC
Hmm similar problem occurs with gnome-autogen's testing of automake:
   testing automake-1.11... /usr/bin/perl: /opt/gnome2/lib/libfreebl3.so: version `NSSRAWHASH_3.12.3' not found (required by /lib/libcrypt.so.1)
Comment 3 Kjartan Maraas 2010-05-18 16:17:18 UTC
Also, nss fails to patch after the last version update. The soname patch fails specifically. After removing that I also hit other build issues later on:

make[3]: Entering directory `/home/kmaraas/src/gnome/nss-3.12.6/mozilla/security/dbm/src'
gcc -o Linux2.6_x86_glibc_PTH_OPT.OBJ/db.o -c -O2 -ansi -D_POSIX_SOURCE -D_BSD_SOURCE -D_XOPEN_SOURCE -fPIC -Di386 -DLINUX2_1  -Wall -Werror-implicit-function-declaration -Wno-switch -pipe -DLINUX -Dlinux -DHAVE_STRERROR -DXP_UNIX -UDEBUG -DNDEBUG -D_REENTRANT -DNSS_ENABLE_ECC -DUSE_UTIL_DIRECTLY -DSTDC_HEADERS -DHAVE_STRERROR -DHAVE_SNPRINTF -DHAVE_SYS_CDEFS_H -DMEMMOVE -D__DBINTERFACE_PRIVATE  -I/usr/include/nspr -I/opt/gnome2/include -I../../../dist/public/dbm -I../../../dist/private/dbm -I../../../dist/include  -I../../../dbm/include  ../../../dbm/src/db.c
In file included from ../../../dbm/src/db.c:50:
../../../dist/public/dbm/mcom_db.h:46:21: error: prtypes.h: Ingen slik fil eller filkatalog
In file included from ../../../dbm/src/db.c:50:
../../../dist/public/dbm/mcom_db.h:231: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘pgno_t’
../../../dist/public/dbm/mcom_db.h:235: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘indx_t’
../../../dist/public/dbm/mcom_db.h:237: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘recno_t’
../../../dist/public/dbm/mcom_db.h:304: error: expected specifier-qualifier-list before ‘uint32’
../../../dist/public/dbm/mcom_db.h:325: error: expected specifier-qualifier-list before ‘uint32’
../../../dist/public/dbm/mcom_db.h:335: error: expected specifier-qualifier-list before ‘uint32’
../../../dist/public/dbm/mcom_db.h:396: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘extern’
../../../dbm/src/db.c:53: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘int’
../../../dbm/src/db.c: In function ‘dbSetOrClearDBLock’:
../../../dbm/src/db.c:62: error: ‘all_databases_locked_closed’ undeclared (first use in this function)
../../../dbm/src/db.c:62: error: (Each undeclared identifier is reported only once
../../../dbm/src/db.c:62: error: for each function it appears in.)
../../../dbm/src/db.c: In function ‘dbopen’:
../../../dbm/src/db.c:73: error: ‘all_databases_locked_closed’ undeclared (first use in this function)
make[3]: *** [Linux2.6_x86_glibc_PTH_OPT.OBJ/db.o] Error 1
make[3]: Leaving directory `/home/kmaraas/src/gnome/nss-3.12.6/mozilla/security/dbm/src'
make[2]: *** [libs] Error 2
make[2]: Leaving directory `/home/kmaraas/src/gnome/nss-3.12.6/mozilla/security/dbm'
make[1]: *** [build_dbm] Error 2
make[1]: Leaving directory `/home/kmaraas/src/gnome/nss-3.12.6/mozilla/security/nss'
make: *** [all] Error 2
*** Error during phase build of nss: ########## Error ru
Comment 4 Tshepang Lekhonkhobe 2010-11-22 19:52:01 UTC
While building 2.32 moduleset, I get:

drbg.c: In function ‘RNG_RandomUpdate’:
drbg.c:510: error: size of array ‘arg’ is negative
drbg.c:513: warning: large integer implicitly truncated to unsigned type
make[4]: *** [Linux2.6_x86_glibc_PTH_OPT.OBJ/Linux_SINGLE_SHLIB/drbg.o] Error 1
make[4]: Leaving directory `/home/wena/src/gnome/nss-3.12.6/mozilla/security/nss/lib/freebl'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/home/wena/src/gnome/nss-3.12.6/mozilla/security/nss/lib/freebl'
make[2]: *** [libs] Error 2
make[2]: Leaving directory `/home/wena/src/gnome/nss-3.12.6/mozilla/security/nss/lib'
make[1]: *** [libs] Error 2
make[1]: Leaving directory `/home/wena/src/gnome/nss-3.12.6/mozilla/security/nss'
make: *** [all] Error 2
Comment 5 André Klapper 2010-11-22 20:02:08 UTC
(In reply to comment #4)
> drbg.c: In function ‘RNG_RandomUpdate’:
> drbg.c:510: error: size of array ‘arg’ is negative

Confirming, but unrelated to this bug report, I'd say.
Comment 6 Craig Keogh 2010-11-24 11:31:23 UTC
Created attachment 175154 [details] [review]
Cleanup nspr and nss patches

Use autogen.sh & autoreconf rather than patching in pre-built configure
files. This aims to avoid patching fail on different nspr & nss
versions.

This patch aims to solve the build problems with the problematic modules that is nspr and nss. If you've had build problems, I'd appreciate if you could test this patch. Apply patch with: git am <filename>
Comment 7 Tshepang Lekhonkhobe 2010-11-24 20:16:12 UTC
I still get the exact same failure. Should I report this as a separate bug since someone already noted that it's not similar to OP?
Comment 8 André Klapper 2010-11-24 20:21:59 UTC
(In reply to comment #7)
> I still get the exact same failure. Should I report this as a separate bug

Not a jhbuild bug. Maybe check nss' bug tracker...
Comment 9 Craig Keogh 2010-12-02 09:45:31 UTC
Created attachment 175699 [details] [review]
Cleanup nspr and nss patches

This is an updated patch for the new moduleset layout.

Use autogen.sh & autoreconf rather than patching in pre-built configure
files. This aims to avoid patching fail on different nspr & nss
versions.

This patch aims to solve the build problems with the problematic modules that
is nspr and nss. If you've had build problems, I'd appreciate if you could test
this patch. Apply patch with: git am <filename>
Comment 10 Craig Keogh 2010-12-06 00:55:05 UTC
(In reply to comment #4)
> While building 2.32 moduleset, I get:
> 
> drbg.c: In function ‘RNG_RandomUpdate’:
> drbg.c:510: error: size of array ‘arg’ is negative

That is https://bugzilla.mozilla.org/show_bug.cgi?id=483135
It seems you have a 32bit / 64bit mix-up.
Comment 11 Craig Keogh 2010-12-06 01:01:42 UTC
(In reply to comment #4)
> While building 2.32 moduleset, I get:
> 
> drbg.c: In function ‘RNG_RandomUpdate’:
> drbg.c:510: error: size of array ‘arg’ is negative

This bug has some more info - even if not on s390 arch.
https://bugzilla.mozilla.org/show_bug.cgi?id=519654
Comment 12 Craig Keogh 2010-12-10 10:17:55 UTC
Comment on attachment 175699 [details] [review]
Cleanup nspr and nss patches

Committed.

http://git.gnome.org/browse/jhbuild/commit/?id=0f2a9517aee84b8bd53ee33130c9d687dd98ed97