After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618482 - [StThemeNode] Don't treat min-width and min-height as a fixed size
[StThemeNode] Don't treat min-width and min-height as a fixed size
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 618460
 
 
Reported: 2010-05-12 20:51 UTC by Colin Walters
Modified: 2010-05-13 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[StThemeNode] Don't treat min-width and min-height as a fixed size (1.17 KB, patch)
2010-05-12 20:51 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2010-05-12 20:51:05 UTC 
I have no idea why there existed code that if we saw e.g. min-width
without a width, we assigned min-width to ->width, thus effectively
treating it as a maximum.

Just delete that bit.
Comment 1 Colin Walters 2010-05-12 20:51:07 UTC 
Created attachment 160928 [details] [review]
[StThemeNode] Don't treat min-width and min-height as a fixed size
Comment 2 Florian Müllner 2010-05-13 14:36:48 UTC 
Review of attachment 160928 [details] [review]:

Looks good to me - it's probably a good idea though to double-check with Dan and Owen who did the original review on bug 598651
Comment 3 Dan Winship 2010-05-13 14:46:44 UTC 
(In reply to comment #2)
> Looks good to me - it's probably a good idea though to double-check with Dan
> and Owen who did the original review on bug 598651

rereading 598651, it looks like that was a behavior change between Steve's first and second patches, based on a misunderstanding of something Owen said, which I didn't catch when re-reviewing it. So yes, it should go.